Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1554545

Re: [PATCH] libata-eh: Use switch() instead of sparse array for protocol strings

From Tejun Heo <tj@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] libata-eh: Use switch() instead of sparse array for protocol strings
Date 2017-01-09 18:40 +0100
Message-ID <sXM5k-77I-59@gated-at.bofh.it> (permalink)
References (1 earlier) <sXK3w-5SD-35@gated-at.bofh.it> <sXKmS-5Z0-25@gated-at.bofh.it> <sXKGe-6kS-9@gated-at.bofh.it> <sXL9h-6vS-41@gated-at.bofh.it> <sXLVE-74k-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hello,

On Mon, Jan 09, 2017 at 09:27:23AM -0800, Christoph Hellwig wrote:
> On Mon, Jan 09, 2017 at 05:30:02PM +0100, Geert Uytterhoeven wrote:
> > > ata_force_param_buf is __initdata and shouldn't really matter.
> > 
> > It mainly matters because of e.g. bootloader limitations.
> 
> Do we need a full 4k for the force parameters?  What would a typical
> command line for it look like?

Maybe a couple hundreds bytes at max, but it's a bit weird to restrict
this given that it is bss, not gigantic and __initdata.  What kind of
bootloader limitations are we talking about?

Thanks.

-- 
tejun

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] libata-eh: Use switch() instead of sparse array for protocol strings Geert Uytterhoeven <geert@linux-m68k.org> - 2017-01-09 16:00 +0100
  Re: [PATCH] libata-eh: Use switch() instead of sparse array for  protocol strings Tejun Heo <tj@kernel.org> - 2017-01-09 16:30 +0100
    Re: [PATCH] libata-eh: Use switch() instead of sparse array for  protocol strings Geert Uytterhoeven <geert@linux-m68k.org> - 2017-01-09 16:50 +0100
      Re: [PATCH] libata-eh: Use switch() instead of sparse array for  protocol strings Tejun Heo <tj@kernel.org> - 2017-01-09 17:10 +0100
        Re: [PATCH] libata-eh: Use switch() instead of sparse array for  protocol strings Christoph Hellwig <hch@infradead.org> - 2017-01-09 17:30 +0100
          Re: [PATCH] libata-eh: Use switch() instead of sparse array for  protocol strings Christoph Hellwig <hch@infradead.org> - 2017-01-09 18:30 +0100
            Re: [PATCH] libata-eh: Use switch() instead of sparse array for  protocol strings Tejun Heo <tj@kernel.org> - 2017-01-09 18:40 +0100
        Re: [PATCH] libata-eh: Use switch() instead of sparse array for  protocol strings Geert Uytterhoeven <geert@linux-m68k.org> - 2017-01-09 17:40 +0100
          Re: [PATCH] libata-eh: Use switch() instead of sparse array for  protocol strings Christoph Hellwig <hch@infradead.org> - 2017-01-09 18:30 +0100
            Re: [PATCH] libata-eh: Use switch() instead of sparse array for  protocol strings Tejun Heo <tj@kernel.org> - 2017-01-09 18:40 +0100
              Re: [PATCH] libata-eh: Use switch() instead of sparse array for  protocol strings Geert Uytterhoeven <geert@linux-m68k.org> - 2017-01-09 19:30 +0100
                Re: [PATCH] libata-eh: Use switch() instead of sparse array for  protocol strings Tejun Heo <tj@kernel.org> - 2017-01-09 20:50 +0100
                Re: [PATCH] libata-eh: Use switch() instead of sparse array for  protocol strings Geert Uytterhoeven <geert@linux-m68k.org> - 2017-01-09 21:30 +0100
                Re: [PATCH] libata-eh: Use switch() instead of sparse array for  protocol strings Tejun Heo <tj@kernel.org> - 2017-01-09 21:40 +0100

csiph-web