Re: [PATCH V5 04/17] blk-throttle: configure bps/iops limit for cgroup in low limit

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V5 04/17] blk-throttle: configure bps/iops limit for cgroup in low limit
Date	2017-01-09 18:40 +0100
Message-ID	<sXM5k-77I-55@gated-at.bofh.it> (permalink)
References	<sOKYO-1X6-11@gated-at.bofh.it> <sOKYP-1X6-55@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello,

On Thu, Dec 15, 2016 at 12:32:55PM -0800, Shaohua Li wrote:
> each queue will have a state machine. Initially queue is in LIMIT_LOW
> state, which means all cgroups will be throttled according to their low
> limit. After all cgroups with low limit cross the limit, the queue state
> gets upgraded to LIMIT_MAX state.

As with the previous patch, I don't think it's correct to default to
MAX for LIMIT_LOW and then enforce it.  Without specific
configuration, a cgroup should always be above below (so, no latency
requirement) and below max (no hard limiting).

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH V5 04/17] blk-throttle: configure bps/iops limit for  cgroup in low limit Tejun Heo <tj@kernel.org> - 2017-01-09 18:40 +0100

csiph-web