Re: [PATCH v2] fscrypt: Factor out bio specific functions

From	Christoph Hellwig <hch@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] fscrypt: Factor out bio specific functions
Date	2017-01-09 14:40 +0100
Message-ID	<sXIl5-4NO-51@gated-at.bofh.it> (permalink)
References	(3 earlier) <sVtTb-4n9-9@gated-at.bofh.it> <sVypP-7EJ-7@gated-at.bofh.it> <sW0m6-1bZ-37@gated-at.bofh.it> <sX4QF-4um-3@gated-at.bofh.it> <sX7Ye-6od-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Jan 07, 2017 at 11:40:15PM +0100, Richard Weinberger wrote:
> Kconfig is tricky. We face a build error with CONFIG_BLOCK=n with UBIFS_FS_ENCRYPTION enabled.
> UBIFS file encryption does "select FS_ENCRYPTION" just like ext4 and f2fs.
> This will enable ENCRYPTION even when no block support is available.

It's the good old select vs depends mess once again.

> I can make UBIFS depend on BLOCK as intermediate fix.
> But the real fix is this patch.

And despite the diffstat it's simple and trivial as it just moves code.
There is no good reason not to take it for 4.10.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] fscrypt: Factor out bio specific functions Eric Biggers <ebiggers3@gmail.com> - 2017-01-04 21:30 +0100
  Re: [PATCH v2] fscrypt: Factor out bio specific functions Richard Weinberger <richard@nod.at> - 2017-01-05 00:00 +0100
  Re: [PATCH v2] fscrypt: Factor out bio specific functions Theodore Ts'o <tytso@mit.edu> - 2017-01-07 20:30 +0100
    Re: [PATCH v2] fscrypt: Factor out bio specific functions Richard Weinberger <richard@nod.at> - 2017-01-07 23:50 +0100
      Re: [PATCH v2] fscrypt: Factor out bio specific functions Christoph Hellwig <hch@infradead.org> - 2017-01-09 14:40 +0100

csiph-web