Re: [PATCH v2] fscrypt: Factor out bio specific functions

From	Richard Weinberger <richard@nod.at>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] fscrypt: Factor out bio specific functions
Date	2017-01-07 23:50 +0100
Message-ID	<sX7Ye-6od-7@gated-at.bofh.it> (permalink)
References	(2 earlier) <sUWaR-5J3-7@gated-at.bofh.it> <sVtTb-4n9-9@gated-at.bofh.it> <sVypP-7EJ-7@gated-at.bofh.it> <sW0m6-1bZ-37@gated-at.bofh.it> <sX4QF-4um-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Ted,

Am 07.01.2017 um 20:24 schrieb Theodore Ts'o:
> On Wed, Jan 04, 2017 at 12:10:43PM -0800, Eric Biggers wrote:
>>
>> I thought you're supposed to be able to build the kernel no matter how it's
>> configured.  If this patch is really too large for 4.10 then perhaps we should
>> make FS_ENCRYPTION select CONFIG_BLOCK instead?
> 
> We already have FS_ENCRYPTIOn depending on BLOCK, so this is *not*
> fixing a build break.

Kconfig is tricky. We face a build error with CONFIG_BLOCK=n with UBIFS_FS_ENCRYPTION enabled.
UBIFS file encryption does "select FS_ENCRYPTION" just like ext4 and f2fs.
This will enable ENCRYPTION even when no block support is available.

I can make UBIFS depend on BLOCK as intermediate fix.
But the real fix is this patch.

Thanks,
//richard

Thread

Re: [PATCH v2] fscrypt: Factor out bio specific functions Eric Biggers <ebiggers3@gmail.com> - 2017-01-04 21:30 +0100
  Re: [PATCH v2] fscrypt: Factor out bio specific functions Richard Weinberger <richard@nod.at> - 2017-01-05 00:00 +0100
  Re: [PATCH v2] fscrypt: Factor out bio specific functions Theodore Ts'o <tytso@mit.edu> - 2017-01-07 20:30 +0100
    Re: [PATCH v2] fscrypt: Factor out bio specific functions Richard Weinberger <richard@nod.at> - 2017-01-07 23:50 +0100
      Re: [PATCH v2] fscrypt: Factor out bio specific functions Christoph Hellwig <hch@infradead.org> - 2017-01-09 14:40 +0100

csiph-web