Re: [PATCH] PM / domains: Fix 'may be used uninitialized' build warning

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news2.arglkargh.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] PM / domains: Fix 'may be used uninitialized' build warning
Date	Fri, 06 Jan 2017 02:40:02 +0100
Message-ID	<sWrFE-2MO-15@gated-at.bofh.it> (permalink)
References	<sU3Hs-3Ks-37@gated-at.bofh.it>
User-Agent	KMail/4.14.10 (Linux/4.10.0-rc1+; KDE/4.14.9; x86_64; ; )
MIME-Version	1.0
Content-Transfer-Encoding	8BIT
Content-Type	text/plain; charset="utf-8"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	32
Organization	linux.* mail to news gateway
X-Original-Cc	torvalds@linux-foundation.org, Kevin Hilman <khilman@kernel.org>, Ulf Hansson <ulf.hansson@linaro.org>, Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Fri, 06 Jan 2017 02:28:42 +0100
X-Original-Message-ID	<1783360.Wg7bKzXGUa@aspire.rjw.lan>
X-Original-References	<1483097651-7172-1-git-send-email-augustocaringi@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1552451

Show key headers only | View raw

On Friday, December 30, 2016 11:34:08 AM Augusto Mecking Caringi wrote:
> This patch fixes the following gcc warning:
> 
> drivers/base/power/domain.c: In function ‘genpd_runtime_resume’:
> drivers/base/power/domain.c:642:14: warning: ‘time_start’ may be used
> uninitialized in this function [-Wmaybe-uninitialized]
>    elapsed_ns = ktime_to_ns(ktime_sub(ktime_get(), time_start)
> 
> The same problem (in another function in this same file) was fixed in
> commit d33d5a6c88fc (avoid spurious "may be used uninitialized" warning)
> 
> Signed-off-by: Augusto Mecking Caringi <augustocaringi@gmail.com>
> ---
>  drivers/base/power/domain.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index a5e1262..2997026 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -626,6 +626,7 @@ static int genpd_runtime_resume(struct device *dev)
>  
>   out:
>  	/* Measure resume latency. */
> +	time_start = 0;
>  	if (timed && runtime_pm)
>  		time_start = ktime_get();

Applied.

Thanks,
Rafael

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] PM / domains: Fix 'may be used uninitialized' build warning "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-01-06 02:40 +0100

csiph-web