Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1552451

Re: [PATCH] PM / domains: Fix 'may be used uninitialized' build warning

Show all headers | View raw

On Friday, December 30, 2016 11:34:08 AM Augusto Mecking Caringi wrote:
> This patch fixes the following gcc warning:
> 
> drivers/base/power/domain.c: In function ‘genpd_runtime_resume’:
> drivers/base/power/domain.c:642:14: warning: ‘time_start’ may be used
> uninitialized in this function [-Wmaybe-uninitialized]
>    elapsed_ns = ktime_to_ns(ktime_sub(ktime_get(), time_start)
> 
> The same problem (in another function in this same file) was fixed in
> commit d33d5a6c88fc (avoid spurious "may be used uninitialized" warning)
> 
> Signed-off-by: Augusto Mecking Caringi <augustocaringi@gmail.com>
> ---
>  drivers/base/power/domain.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index a5e1262..2997026 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -626,6 +626,7 @@ static int genpd_runtime_resume(struct device *dev)
>  
>   out:
>  	/* Measure resume latency. */
> +	time_start = 0;
>  	if (timed && runtime_pm)
>  		time_start = ktime_get();

Applied.

Thanks,
Rafael

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] PM / domains: Fix 'may be used uninitialized' build warning "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-01-06 02:40 +0100

csiph-web