Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1553522

Re: [PATCH] ssb: main.c: This patch removes unnecessary return statement using spatch tool

Show all headers | View raw

Hi Rahul,

On Sat, Jan 7, 2017 at 2:20 AM, Rahul Krishnan
<mrahul.krishnan@gmail.com> wrote:
> This patch removes unnecessary return statement using spatch.

This doesn't describe the patch.

> Signed-off-by: Rahul Krishnan <mrahul.krishnan@gmail.com>
> ---
>  drivers/ssb/main.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
> index d1a7507..ae3b7fe 100644
> --- a/drivers/ssb/main.c
> +++ b/drivers/ssb/main.c
> @@ -1,4 +1,4 @@
> -/*
> + patch /home/rahul/git/kernels/staging/drivers//*

What is the purpose of this change, won't this cause the file to fail
to compile?

>   * Sonics Silicon Backplane
>   * Subsystem core
>   *
> @@ -1272,9 +1272,7 @@ u32 ssb_admatch_size(u32 adm)
>         default:
>                 SSB_WARN_ON(1);
>         }
> -       size = (1 << (size + 1));
> -
> -       return size;
> +       return (1 << (size + 1));

Is the size variable used elsewhere? If not, it's declaration should
probably be removed.

Also, there should be a blank line before the return statement.

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ssb: main.c: This patch removes unnecessary return statement  using spatch tool Rahul Krishnan <mrahul.krishnan@gmail.com> - 2017-01-06 16:30 +0100
  Re: [PATCH] ssb: main.c: This patch removes unnecessary return  statement using spatch tool Rafał Miłecki <zajec5@gmail.com> - 2017-01-06 23:40 +0100
    Re: [PATCH] ssb: main.c: This patch removes unnecessary return  statement using spatch tool Rafał Miłecki <zajec5@gmail.com> - 2017-01-06 23:50 +0100
    Re: [PATCH] ssb: main.c: This patch removes unnecessary return  statement using spatch tool Michael Büsch <m@bues.ch> - 2017-01-07 00:40 +0100
  Re: [PATCH] ssb: main.c: This patch removes unnecessary return  statement using spatch tool Julian Calaby <julian.calaby@gmail.com> - 2017-01-07 02:00 +0100
  Re: [PATCH] ssb: main.c: This patch removes unnecessary return  statement using spatch tool kbuild test robot <lkp@intel.com> - 2017-01-07 14:50 +0100

csiph-web