Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1553504

Re: [PATCH] ssb: main.c: This patch removes unnecessary return statement using spatch tool

From Michael Büsch <m@bues.ch>
Newsgroups linux.kernel
Subject Re: [PATCH] ssb: main.c: This patch removes unnecessary return statement using spatch tool
Date 2017-01-07 00:40 +0100
Message-ID <sWMh4-Fc-21@gated-at.bofh.it> (permalink)
References <sWECR-3O1-11@gated-at.bofh.it> <sWLl0-8sx-31@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

> > @@ -1272,9 +1272,7 @@ u32 ssb_admatch_size(u32 adm)
> >         default:
> >                 SSB_WARN_ON(1);
> >         }
> > -       size = (1 << (size + 1));
> > -
> > -       return size;
> > +       return (1 << (size + 1));
> >  }
> >  EXPORT_SYMBOL(ssb_admatch_size);  

I'm all for cleaning up code, but I don't really see how this
change improves the code.

-- 
Michael

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] ssb: main.c: This patch removes unnecessary return statement  using spatch tool Rahul Krishnan <mrahul.krishnan@gmail.com> - 2017-01-06 16:30 +0100
  Re: [PATCH] ssb: main.c: This patch removes unnecessary return  statement using spatch tool Rafał Miłecki <zajec5@gmail.com> - 2017-01-06 23:40 +0100
    Re: [PATCH] ssb: main.c: This patch removes unnecessary return  statement using spatch tool Rafał Miłecki <zajec5@gmail.com> - 2017-01-06 23:50 +0100
    Re: [PATCH] ssb: main.c: This patch removes unnecessary return  statement using spatch tool Michael Büsch <m@bues.ch> - 2017-01-07 00:40 +0100
  Re: [PATCH] ssb: main.c: This patch removes unnecessary return  statement using spatch tool Julian Calaby <julian.calaby@gmail.com> - 2017-01-07 02:00 +0100
  Re: [PATCH] ssb: main.c: This patch removes unnecessary return  statement using spatch tool kbuild test robot <lkp@intel.com> - 2017-01-07 14:50 +0100

csiph-web