Re: [PATCH 3/3] ext4: Find desired extent in ext4_ext_shift_extents() using binsearch

Path	csiph.com!news.mixmin.net!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	Roman Penyaev <roman.penyaev@profitbricks.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] ext4: Find desired extent in ext4_ext_shift_extents() using binsearch
Date	Fri, 06 Jan 2017 21:30:02 +0100
Message-ID	<sWJjc-71s-9@gated-at.bofh.it> (permalink)
References	<sVanv-6UV-3@gated-at.bofh.it> <sVanv-6UV-15@gated-at.bofh.it> <sVyzw-7Iz-21@gated-at.bofh.it> <sVEbU-3aT-15@gated-at.bofh.it> <sVFAZ-4dw-15@gated-at.bofh.it> <sVYDE-8nf-19@gated-at.bofh.it> <sW3Dk-3ex-29@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=profitbricks-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=w5vILhBe0YotopajHlti4J+U5+RJeuBdi1dvdd9w2WQ=; b=VNforNkZ76tQdCP5CzzmNdcycwyd0I9v9L9lkM28aYVqlTfcuz2ClLqZ7ElBLAP/34 +kvJF7BZl+AXjX9s2WHzXFgEeuTdtPaNe/A2lMG7O4/jrsHU+vRuV7Cot/Y0pYdWLG5d tdvSoV3ZWL3q6H9mWiM0BaGYxS5AM7TMyDiTS0CHZeBDUB+sbrG2Q68D+lxv2aFBeRL8 lhiB6px7YOWOIqco1O9fixVjBkzPso4RLom/ZWd6+u2Yq5MGXTOz1jOayQiav2UHYvrR PtEttl3hfmzHm2HlLDaDCqmKxw/da4Zu1DpKhKnYh85aF2Gsgqin510gUHJk6RrrCsRc R/9w==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=w5vILhBe0YotopajHlti4J+U5+RJeuBdi1dvdd9w2WQ=; b=uiNf48lCoDBIv9j0SyII4T21RqHQxQT1DtIkgdeN2wUwfHOBTzcQUPWZefhLPv1TUV Lo6DjlBPc/H5qcqF67seUI7pTBwzn2i7tbfp84s1nLqlQ7+s14H8XOb8bYddwfhEbrLt QlXg42T17G/TxVmj7kpngzhaaGX2E18fwisNkXlJToNvCF9KOSVWmO2wbDsq8cdu27P+ 7+UcFn7d4ymQxMf/+K6TTFENihjBSD9MbxyOEZHv5XoY+sYysy2N2df6N3fY55VbBioI enaMufGfHDRWIClfYFKTTR3rcNWOXcpglBsHP3qE35WVxLGoGxchFJJTnPv+mn2O1M9A H+BA==
X-Gm-Message-State	AIkVDXJUIuIcUyxsk0do2j4TpE/+IUmdii45TSRLzq44Qi6YFFQkFa1kH0fXgIt1oefRn+YeB1/yNpU+ogboIeDP
X-Received	by 10.36.66.76 with SMTP id i73mr408244itb.50.1483734100184; Fri, 06 Jan 2017 12:21:40 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	27
Organization	linux.* mail to news gateway
X-Original-Date	Fri, 6 Jan 2017 21:21:19 +0100
X-Original-Message-ID	<CAJrWOzDDy+GETUTAiRT7Sunj_LK8A8Uq9Nodwd+UBFpvY2WsXg@mail.gmail.com>
X-Original-References	<20170102125450.22807-1-roman.penyaev@profitbricks.com> <20170102125450.22807-4-roman.penyaev@profitbricks.com> <20170103144041.t5lmorkdqqljnwvl@thunk.org> <CAJrWOzAsAyhpBOSm=Ot=iffqwCV7w8jGXLFieTxY11VTo9rOpA@mail.gmail.com> <20170103221510.dkrxqav7qrq772ji@thunk.org> <CAJrWOzA467XZOpZmaGr6_z+nwNAxJZXYFmb4azS7Haag4dtWAQ@mail.gmail.com> <20170104235818.v3fwchrjnxnhuble@thunk.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1553082

Show key headers only | View raw

On Thu, Jan 5, 2017 at 12:58 AM, Theodore Ts'o <tytso@mit.edu> wrote:
> It looks like the original (before your patch) 1k failures due to a
> bug introduced via the block.git tree, which has since been fixed in
> Linus's mainline tree as of today.  It wouldn't surprise me if the bug
> interacted poorly your changes, so things will probably better with
> your patches applied directly on top of the tip of Linus's tree.
>
> That being said, it looks like there were still regressions introduced
> on the 4k configuration, so I'm in the middle of rerunning my baseline
> and trying out your patches as well.

I found a bug in my third patch, where I try to optimize linear search.
I missed the fact, that ext4_ext_binsearch() searches for the closest
extent from the left, but this linear search code does search for closest
extent from the right.

I ran the 'kvm-xfstests.sh -c 4k -g auto' against b25ead75e7b6 4.10-rc2
with and without my changes.  No failures.

1k configuration was run against latest Linus's mainline.  Also no
regressions were found: these two "generic/270, generic/273" fail
regardless my changes.

I will resend the patchset without latest patch shortly.

--
Roman

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 3/3] ext4: Find desired extent in ext4_ext_shift_extents()  using binsearch Roman Penyaev <roman.penyaev@profitbricks.com> - 2017-01-03 21:50 +0100
  Re: [PATCH 3/3] ext4: Find desired extent in ext4_ext_shift_extents()  using binsearch Roman Penyaev <roman.penyaev@profitbricks.com> - 2017-01-04 19:40 +0100
    Re: [PATCH 3/3] ext4: Find desired extent in  ext4_ext_shift_extents() using binsearch Theodore Ts'o <tytso@mit.edu> - 2017-01-05 01:00 +0100
      Re: [PATCH 3/3] ext4: Find desired extent in ext4_ext_shift_extents()  using binsearch Roman Penyaev <roman.penyaev@profitbricks.com> - 2017-01-05 09:10 +0100
      Re: [PATCH 3/3] ext4: Find desired extent in ext4_ext_shift_extents()  using binsearch Roman Penyaev <roman.penyaev@profitbricks.com> - 2017-01-06 21:30 +0100

csiph-web