Re: [PATCH 3/3] ext4: Find desired extent in ext4_ext_shift_extents() using binsearch

From	Roman Penyaev <roman.penyaev@profitbricks.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] ext4: Find desired extent in ext4_ext_shift_extents() using binsearch
Date	2017-01-06 21:30 +0100
Message-ID	<sWJjc-71s-9@gated-at.bofh.it> (permalink)
References	(2 earlier) <sVyzw-7Iz-21@gated-at.bofh.it> <sVEbU-3aT-15@gated-at.bofh.it> <sVFAZ-4dw-15@gated-at.bofh.it> <sVYDE-8nf-19@gated-at.bofh.it> <sW3Dk-3ex-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jan 5, 2017 at 12:58 AM, Theodore Ts'o <tytso@mit.edu> wrote:
> It looks like the original (before your patch) 1k failures due to a
> bug introduced via the block.git tree, which has since been fixed in
> Linus's mainline tree as of today.  It wouldn't surprise me if the bug
> interacted poorly your changes, so things will probably better with
> your patches applied directly on top of the tip of Linus's tree.
>
> That being said, it looks like there were still regressions introduced
> on the 4k configuration, so I'm in the middle of rerunning my baseline
> and trying out your patches as well.

I found a bug in my third patch, where I try to optimize linear search.
I missed the fact, that ext4_ext_binsearch() searches for the closest
extent from the left, but this linear search code does search for closest
extent from the right.

I ran the 'kvm-xfstests.sh -c 4k -g auto' against b25ead75e7b6 4.10-rc2
with and without my changes.  No failures.

1k configuration was run against latest Linus's mainline.  Also no
regressions were found: these two "generic/270, generic/273" fail
regardless my changes.

I will resend the patchset without latest patch shortly.

--
Roman

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 3/3] ext4: Find desired extent in ext4_ext_shift_extents()  using binsearch Roman Penyaev <roman.penyaev@profitbricks.com> - 2017-01-03 21:50 +0100
  Re: [PATCH 3/3] ext4: Find desired extent in ext4_ext_shift_extents()  using binsearch Roman Penyaev <roman.penyaev@profitbricks.com> - 2017-01-04 19:40 +0100
    Re: [PATCH 3/3] ext4: Find desired extent in  ext4_ext_shift_extents() using binsearch Theodore Ts'o <tytso@mit.edu> - 2017-01-05 01:00 +0100
      Re: [PATCH 3/3] ext4: Find desired extent in ext4_ext_shift_extents()  using binsearch Roman Penyaev <roman.penyaev@profitbricks.com> - 2017-01-05 09:10 +0100
      Re: [PATCH 3/3] ext4: Find desired extent in ext4_ext_shift_extents()  using binsearch Roman Penyaev <roman.penyaev@profitbricks.com> - 2017-01-06 21:30 +0100

csiph-web