Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1549806

Re: [RFC PATCH v2] crypto: Add IV generation algorithms

Show all headers | View raw

Hi Binoy,

On Tue, Dec 13, 2016 at 02:19:09PM +0530, Binoy Jayan wrote:
> Currently, the iv generation algorithms are implemented in dm-crypt.c.
> The goal is to move these algorithms from the dm layer to the kernel
> crypto layer by implementing them as template ciphers so they can be
> implemented in hardware for performance. As part of this patchset, the
> iv-generation code is moved from the dm layer to the crypto layer and
> adapt the dm-layer to send a whole 'bio' (as defined in the block layer)
> at a time. Each bio contains the in memory representation of physically
> contiguous disk blocks. The dm layer sets up a chained scatterlist of
> these blocks split into physically contiguous segments in memory so that
> DMA can be performed. The iv generation algorithms implemented in geniv.c
> include plain, plain64, essiv, benbi, null, lmk and tcw.
>

Good idea. I wanted to test the patch but alas it does not apply cleanly.
You seem to have a blank line at the end of files and other small
transgressions that makes checkpatch grumpy.

<snip>

Also...

>
> Not-signed-off-by: Binoy Jayan <binoy.jayan@linaro.org>


What is Not-signed-off-by ? :-)

Thanks,
Gilad Ben-Yossef

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH v2] IV Generation algorithms for dm-crypt Binoy Jayan <binoy.jayan@linaro.org> - 2016-12-13 10:00 +0100
  Re: [RFC PATCH v2] crypto: Add IV generation algorithms Milan Broz <gmazyland@gmail.com> - 2016-12-13 11:10 +0100
    Re: [RFC PATCH v2] crypto: Add IV generation algorithms Binoy Jayan <binoy.jayan@linaro.org> - 2016-12-14 07:20 +0100
    Re: [RFC PATCH v2] crypto: Add IV generation algorithms Binoy Jayan <binoy.jayan@linaro.org> - 2016-12-16 07:00 +0100
    Re: [RFC PATCH v2] crypto: Add IV generation algorithms Herbert Xu <herbert@gondor.apana.org.au> - 2016-12-22 10:00 +0100
      Re: [RFC PATCH v2] crypto: Add IV generation algorithms Binoy Jayan <binoy.jayan@linaro.org> - 2016-12-22 12:00 +0100
        Re: [RFC PATCH v2] crypto: Add IV generation algorithms Herbert Xu <herbert@gondor.apana.org.au> - 2016-12-23 09:00 +0100
          Re: [RFC PATCH v2] crypto: Add IV generation algorithms Binoy Jayan <binoy.jayan@linaro.org> - 2016-12-29 10:30 +0100
            Re: [RFC PATCH v2] crypto: Add IV generation algorithms Herbert Xu <herbert@gondor.apana.org.au> - 2016-12-30 11:30 +0100
              Re: [RFC PATCH v2] crypto: Add IV generation algorithms Binoy Jayan <binoy.jayan@linaro.org> - 2017-01-02 07:50 +0100
                Re: [RFC PATCH v2] crypto: Add IV generation algorithms Herbert Xu <herbert@gondor.apana.org.au> - 2017-01-02 08:00 +0100
                Re: [RFC PATCH v2] crypto: Add IV generation algorithms Binoy Jayan <binoy.jayan@linaro.org> - 2017-01-02 08:10 +0100
                Re: [RFC PATCH v2] crypto: Add IV generation algorithms Binoy Jayan <binoy.jayan@linaro.org> - 2017-01-05 07:10 +0100
  Re: [RFC PATCH v2] crypto: Add IV generation algorithms Gilad Ben-Yossef <gilad@benyossef.com> - 2017-01-03 15:30 +0100
    Re: [RFC PATCH v2] crypto: Add IV generation algorithms Binoy Jayan <binoy.jayan@linaro.org> - 2017-01-04 06:30 +0100
  Re: [RFC PATCH v2] crypto: Add IV generation algorithms Ondrej Mosnáček          <omosnacek+linux-crypto@gmail.com> - 2017-01-11 16:00 +0100

csiph-web