Re: [RFC PATCH v2] crypto: Add IV generation algorithms

From	Binoy Jayan <binoy.jayan@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH v2] crypto: Add IV generation algorithms
Date	2017-01-02 07:50 +0100
Message-ID	<sV4Br-2ML-7@gated-at.bofh.it> (permalink)
References	(3 earlier) <sR7oe-75y-13@gated-at.bofh.it> <sR9gl-8pD-9@gated-at.bofh.it> <sRsVH-41t-7@gated-at.bofh.it> <sTFc6-4L0-3@gated-at.bofh.it> <sU2BH-364-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Herbert,

On 30 December 2016 at 15:57, Herbert Xu <herbert@gondor.apana.org.au> wrote:

> This is just a matter of structuring the key for the IV generator.
> The IV generator's key in this case should be a combination of the
> key to the underlying CBC plus the set of all keys for the IV
> generator itself.  It should then allocate the required number of
> tfms as is currently done by crypt_alloc_tfms in dm-crypt.

Since I used template ciphers for the iv algorithms, I use
crypto_spawn_skcipher_alg and skcipher_register_instance
for creating the underlying cbc algorithm. I guess you suggest
to change that to make use of crypto_alloc_skcipher.

Even if ciphers are allocated this way, all the encryption requests
for cbc should still go through IV generators? So that should mean,
create one instance of IV generator using 'crypto_alloc_skcipher'
and create tfms_count instances of the generator depending on the
number of keys.

Thanks,
Binoy

Thread

[RFC PATCH v2] IV Generation algorithms for dm-crypt Binoy Jayan <binoy.jayan@linaro.org> - 2016-12-13 10:00 +0100
  Re: [RFC PATCH v2] crypto: Add IV generation algorithms Milan Broz <gmazyland@gmail.com> - 2016-12-13 11:10 +0100
    Re: [RFC PATCH v2] crypto: Add IV generation algorithms Binoy Jayan <binoy.jayan@linaro.org> - 2016-12-14 07:20 +0100
    Re: [RFC PATCH v2] crypto: Add IV generation algorithms Binoy Jayan <binoy.jayan@linaro.org> - 2016-12-16 07:00 +0100
    Re: [RFC PATCH v2] crypto: Add IV generation algorithms Herbert Xu <herbert@gondor.apana.org.au> - 2016-12-22 10:00 +0100
      Re: [RFC PATCH v2] crypto: Add IV generation algorithms Binoy Jayan <binoy.jayan@linaro.org> - 2016-12-22 12:00 +0100
        Re: [RFC PATCH v2] crypto: Add IV generation algorithms Herbert Xu <herbert@gondor.apana.org.au> - 2016-12-23 09:00 +0100
          Re: [RFC PATCH v2] crypto: Add IV generation algorithms Binoy Jayan <binoy.jayan@linaro.org> - 2016-12-29 10:30 +0100
            Re: [RFC PATCH v2] crypto: Add IV generation algorithms Herbert Xu <herbert@gondor.apana.org.au> - 2016-12-30 11:30 +0100
              Re: [RFC PATCH v2] crypto: Add IV generation algorithms Binoy Jayan <binoy.jayan@linaro.org> - 2017-01-02 07:50 +0100
                Re: [RFC PATCH v2] crypto: Add IV generation algorithms Herbert Xu <herbert@gondor.apana.org.au> - 2017-01-02 08:00 +0100
                Re: [RFC PATCH v2] crypto: Add IV generation algorithms Binoy Jayan <binoy.jayan@linaro.org> - 2017-01-02 08:10 +0100
  Re: [RFC PATCH v2] crypto: Add IV generation algorithms Gilad Ben-Yossef <gilad@benyossef.com> - 2017-01-03 15:30 +0100

csiph-web