Re: [PATCHv2 0/5] Add generic pinctrl helpers for managing groups and function

From	Gary Bisson <gary.bisson@boundarydevices.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv2 0/5] Add generic pinctrl helpers for managing groups and function
Date	2017-01-02 17:20 +0100
Message-ID	<sVdv3-YY-9@gated-at.bofh.it> (permalink)
References	<sT3Jv-4Zm-3@gated-at.bofh.it> <sU6Fj-5Cx-9@gated-at.bofh.it> <sU7Bn-6ep-7@gated-at.bofh.it> <sU7UJ-6Bu-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Linus, Tony,

On Fri, Dec 30, 2016 at 07:59:57AM -0800, Tony Lindgren wrote:
> * Gary Bisson <gary.bisson@boundarydevices.com> [161230 07:43]:
> > Hi Linus,
> > 
> > On Fri, Dec 30, 2016 at 3:39 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> > > On Tue, Dec 27, 2016 at 6:19 PM, Tony Lindgren <tony@atomide.com> wrote:
> > >
> > >> Here are some changes to add generic helpers for managing pinctrl groups and
> > >> functions.
> > >
> > > I applied it, screwed around with it and pushed to the build servers to see
> > > if it survived.
> > >
> > > I really like the look of this and I hope lots of driver start to use it.
> > >
> > > Gary, I just applied your radix patches for i.MX, can you look if you can
> > > use the GENERIC_PINCTRL_GROUPS and GENERIC_PINMUX_FUCNTIONS
> > > that Tony invented and that I just merged to my devel branch in the
> > > pinctrl tree?
> > 
> > Yes I will have a look. It does sound like a good idea. I'll share my
> > findings beginning of next week.

So I've had a look and indeed I can use some of it. Here is what my
series looks like:
 drivers/pinctrl/freescale/Kconfig       |   3 +-
 drivers/pinctrl/freescale/pinctrl-imx.c | 273
+++++++++-----------------------
 drivers/pinctrl/freescale/pinctrl-imx.h |  33 +---
 3 files changed, 80 insertions(+), 229 deletions(-)

Mainly I've used the generic functions in pinctrl_ops and pinmux_ops and
switched to the generic group/function_desc structures instead of the
imx-specific one that didn't bring anything else.

However I couldn't use the 'add' functions to add elements since the
parsing is done at probe time in its own way. So I've keep the
radix_insert functions. This could be modified though, it just requires
to modify the driver even more which I didn't feel like doing right now.

> OK great. Note that we may be able to come up also with a generic
> iterator function for the node_to_map functions so maybe see if
> you come up with some ideas for that while experimenting :)

I haven't had time to think about a generic node_to_map yet, but I
hopefully will have some time in a near future to think about it. Right
now it doesn't look obvious.

Also, I have some comments about your patches (already applied) which I
will send as a reply to the original patches.

Regards,
Gary

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCHv2 0/5] Add generic pinctrl helpers for managing groups and function Tony Lindgren <tony@atomide.com> - 2016-12-27 18:30 +0100
  [PATCH 1/5] pinctrl: core: Use delayed work for hogs Tony Lindgren <tony@atomide.com> - 2016-12-27 18:30 +0100
    Re: [PATCH 1/5] pinctrl: core: Use delayed work for hogs Linus Walleij <linus.walleij@linaro.org> - 2016-12-30 14:50 +0100
  Re: [PATCHv2 0/5] Add generic pinctrl helpers for managing groups and function Linus Walleij <linus.walleij@linaro.org> - 2016-12-30 15:50 +0100
    Re: [PATCHv2 0/5] Add generic pinctrl helpers for managing groups and function Gary Bisson <gary.bisson@boundarydevices.com> - 2016-12-30 16:50 +0100
      Re: [PATCHv2 0/5] Add generic pinctrl helpers for managing groups  and function Tony Lindgren <tony@atomide.com> - 2016-12-30 17:10 +0100
        Re: [PATCHv2 0/5] Add generic pinctrl helpers for managing groups  and function Gary Bisson <gary.bisson@boundarydevices.com> - 2017-01-02 17:20 +0100

csiph-web