Re: [PATCH 1/5] pinctrl: core: Use delayed work for hogs

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/5] pinctrl: core: Use delayed work for hogs
Date	2016-12-30 14:50 +0100
Message-ID	<sU5Jf-510-3@gated-at.bofh.it> (permalink)
References	<sT3Jv-4Zm-3@gated-at.bofh.it> <sT3Jv-4Zm-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Dec 27, 2016 at 6:19 PM, Tony Lindgren <tony@atomide.com> wrote:

> Having the pin control framework call pin controller functions
> before it's probe has finished is not nice as the pin controller
> device driver does not yet have struct pinctrl_dev handle.
> Let's fix this issue by adding deferred work for late init. This is
> needed to be able to add pinctrl generic helper functions that expect
> to know struct pinctrl_dev handle. Note that we now need to call
> create_pinctrl() directly as we don't want to add the pin controller
> to the list of controllers until the hogs are claimed. We also need
> to pass the pinctrl_dev to the device tree parser functions as they
> otherwise won't find the right controller at this point.
>
> Signed-off-by: Tony Lindgren <tony@atomide.com>

Patch applied.

I felt the code path needed some extra comments so I sent those
as a separate patch.

Yours,
Linus Walleij

Thread

[PATCHv2 0/5] Add generic pinctrl helpers for managing groups and function Tony Lindgren <tony@atomide.com> - 2016-12-27 18:30 +0100
  [PATCH 1/5] pinctrl: core: Use delayed work for hogs Tony Lindgren <tony@atomide.com> - 2016-12-27 18:30 +0100
    Re: [PATCH 1/5] pinctrl: core: Use delayed work for hogs Linus Walleij <linus.walleij@linaro.org> - 2016-12-30 14:50 +0100
  Re: [PATCHv2 0/5] Add generic pinctrl helpers for managing groups and function Linus Walleij <linus.walleij@linaro.org> - 2016-12-30 15:50 +0100
    Re: [PATCHv2 0/5] Add generic pinctrl helpers for managing groups and function Gary Bisson <gary.bisson@boundarydevices.com> - 2016-12-30 16:50 +0100
      Re: [PATCHv2 0/5] Add generic pinctrl helpers for managing groups  and function Tony Lindgren <tony@atomide.com> - 2016-12-30 17:10 +0100
        Re: [PATCHv2 0/5] Add generic pinctrl helpers for managing groups  and function Gary Bisson <gary.bisson@boundarydevices.com> - 2017-01-02 17:20 +0100

csiph-web