[PATCH RESEND] scripts/Lindent: clean up and optimize

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Jean Delvare <jdelvare@suse.de>
Newsgroups	linux.kernel
Subject	[PATCH RESEND] scripts/Lindent: clean up and optimize
Date	Wed, 04 Jan 2017 14:10:02 +0100
Message-ID	<sVTui-55P-49@gated-at.bofh.it> (permalink)
X-Original-To	LKML <linux-kernel@vger.kernel.org>
Organization	SUSE Linux
X-Mailer	Claws Mail 3.12.0 (GTK+ 2.24.31; x86_64-suse-linux-gnu)
MIME-Version	1.0
Content-Type	text/plain; charset=US-ASCII
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	49
X-Original-Cc	Andrew Morton <akpm@linux-foundation.org>
X-Original-Date	Wed, 4 Jan 2017 14:03:56 +0100
X-Original-Message-ID	<20170104140356.162abab2@endymion>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1550759

Show key headers only | View raw

* Add a few blank lines to improve readability.
* Don't call cut 3 times when once is enough.
* Drop a useless semicolon.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
---
This patch was already sent on 2016-08-05.

 scripts/Lindent |   14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

--- linux-4.7.orig/scripts/Lindent	2016-07-04 08:01:00.000000000 +0200
+++ linux-4.7/scripts/Lindent	2016-08-05 11:09:37.896577373 +0200
@@ -1,21 +1,25 @@
 #!/bin/sh
+
 PARAM="-npro -kr -i8 -ts8 -sob -l80 -ss -ncs -cp1"
-RES=`indent --version`
+
+RES=`indent --version | cut -d' ' -f3`
 if [ "$RES" = "" ]; then
 	exit 1
 fi
-V1=`echo $RES | cut -d' ' -f3 | cut -d'.' -f1`
-V2=`echo $RES | cut -d' ' -f3 | cut -d'.' -f2`
-V3=`echo $RES | cut -d' ' -f3 | cut -d'.' -f3`
+V1=`echo $RES | cut -d'.' -f1`
+V2=`echo $RES | cut -d'.' -f2`
+V3=`echo $RES | cut -d'.' -f3`
+
 if [ $V1 -gt 2 ]; then
   PARAM="$PARAM -il0"
 elif [ $V1 -eq 2 ]; then
   if [ $V2 -gt 2 ]; then
-    PARAM="$PARAM -il0";
+    PARAM="$PARAM -il0"
   elif [ $V2 -eq 2 ]; then
     if [ $V3 -ge 10 ]; then
       PARAM="$PARAM -il0"
     fi
   fi
 fi
+
 indent $PARAM "$@"


-- 
Jean Delvare
SUSE L3 Support

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH RESEND] scripts/Lindent: clean up and optimize Jean Delvare <jdelvare@suse.de> - 2017-01-04 14:10 +0100

csiph-web