Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1550759 > unrolled thread

[PATCH RESEND] scripts/Lindent: clean up and optimize

Back to article view | Back to linux.kernel

Contents

  [PATCH RESEND] scripts/Lindent: clean up and optimize Jean Delvare <jdelvare@suse.de> - 2017-01-04 14:10 +0100

#1550759 — [PATCH RESEND] scripts/Lindent: clean up and optimize

* Add a few blank lines to improve readability.
* Don't call cut 3 times when once is enough.
* Drop a useless semicolon.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
---
This patch was already sent on 2016-08-05.

 scripts/Lindent |   14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

--- linux-4.7.orig/scripts/Lindent	2016-07-04 08:01:00.000000000 +0200
+++ linux-4.7/scripts/Lindent	2016-08-05 11:09:37.896577373 +0200
@@ -1,21 +1,25 @@
 #!/bin/sh
+
 PARAM="-npro -kr -i8 -ts8 -sob -l80 -ss -ncs -cp1"
-RES=`indent --version`
+
+RES=`indent --version | cut -d' ' -f3`
 if [ "$RES" = "" ]; then
 	exit 1
 fi
-V1=`echo $RES | cut -d' ' -f3 | cut -d'.' -f1`
-V2=`echo $RES | cut -d' ' -f3 | cut -d'.' -f2`
-V3=`echo $RES | cut -d' ' -f3 | cut -d'.' -f3`
+V1=`echo $RES | cut -d'.' -f1`
+V2=`echo $RES | cut -d'.' -f2`
+V3=`echo $RES | cut -d'.' -f3`
+
 if [ $V1 -gt 2 ]; then
   PARAM="$PARAM -il0"
 elif [ $V1 -eq 2 ]; then
   if [ $V2 -gt 2 ]; then
-    PARAM="$PARAM -il0";
+    PARAM="$PARAM -il0"
   elif [ $V2 -eq 2 ]; then
     if [ $V3 -ge 10 ]; then
       PARAM="$PARAM -il0"
     fi
   fi
 fi
+
 indent $PARAM "$@"


-- 
Jean Delvare
SUSE L3 Support

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web