Re: [PATCH v7 2/2] tpm: add securityfs support for TPM 2.0 firmware event log

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news.roellig-ltd.de!open-news-network.org!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 2/2] tpm: add securityfs support for TPM 2.0 firmware event log
Date	Wed, 04 Jan 2017 14:10:02 +0100
Message-ID	<sVTui-55P-31@gated-at.bofh.it> (permalink)
References	<sN51D-3yp-1@gated-at.bofh.it> <sN51D-3yp-3@gated-at.bofh.it> <sVj7r-52K-21@gated-at.bofh.it> <sVrRn-2Qs-9@gated-at.bofh.it> <sVxtL-70z-11@gated-at.bofh.it> <sVPqF-2eb-5@gated-at.bofh.it>
X-Original-To	Nayna <nayna@linux.vnet.ibm.com>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.33,459,1477983600"; d="scan'208";a="1089788784"
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent	Mutt/1.6.2-neo (2016-08-21)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	43
X-Original-Cc	tpmdd-devel@lists.sourceforge.net, peterhuewe@gmx.de, tpmdd@selhorst.net, jgunthorpe@obsidianresearch.com, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Wed, 4 Jan 2017 15:01:18 +0200
X-Original-Message-ID	<20170104130118.2brkojj65vjhzca3@intel.com>
X-Original-References	<1481434533-3453-1-git-send-email-nayna@linux.vnet.ibm.com> <1481434533-3453-3-git-send-email-nayna@linux.vnet.ibm.com> <20170102221148.gy3mlubrgs4gm6ey@intel.com> <586B5526.9090703@linux.vnet.ibm.com> <20170103133309.lt5k4c37rjq5vcbq@intel.com> <586CB46E.8050207@linux.vnet.ibm.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1550750

Show key headers only | View raw

On Wed, Jan 04, 2017 at 02:08:06PM +0530, Nayna wrote:
> 
> 
> On 01/03/2017 07:03 PM, Jarkko Sakkinen wrote:
> > On Tue, Jan 03, 2017 at 01:09:18PM +0530, Nayna wrote:
> > > 
> > > 
> > > On 01/03/2017 03:42 AM, Jarkko Sakkinen wrote:
> > > > On Sun, Dec 11, 2016 at 12:35:33AM -0500, Nayna Jain wrote:
> > > > > Unlike the device driver support for TPM 1.2, the TPM 2.0 does
> > > > > not support the securityfs pseudo files for displaying the
> > > > > firmware event log.
> > > > > 
> > > > > This patch enables support for providing the TPM 2.0 event log in
> > > > > binary form. TPM 2.0 event log supports a crypto agile format that
> > > > > records multiple digests, which is different from TPM 1.2. This
> > > > > patch enables the tpm_bios_log_setup for TPM 2.0  and adds the
> > > > > event log parser which understand the TPM 2.0 crypto agile format.
> > > > > 
> > > > > Signed-off-by: Nayna Jain <nayna@linux.vnet.ibm.com>
> > > > 
> > > > There is something fundamentally wrong in this commit.
> > > > 
> > > > You must not allow this feature unless CONFIG_OF is set. It is the only
> > > > interface where the supply path of the event log is well defined on
> > > > platforms that include a TPM 2.0 chip.
> > > 
> > > As per current implementation, if ACPI with TPM 2.0 doesn't support event
> > > log, tpm_read_log_acpi() is expected to return rc and tpm_bios_log_setup
> > > will not create securityfs. This is inline with our design for TPM 1.2 event
> > > log.
> > 
> > At minimum you must have a check for TPM_CHIP_FLAG_TPM2 in the beginning
> > of tpm_read_log_acpi. It is wrong to even try to open TCPA in this case.
> 
> Sure, will add this check and return -ENODEV if check passes.

Yeah, this is acceptable for me.

> Thanks & Regards,
>     - Nayna

/Jarkko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v7 2/2] tpm: add securityfs support for TPM 2.0 firmware  event log Nayna <nayna@linux.vnet.ibm.com> - 2017-01-04 09:50 +0100
  Re: [PATCH v7 2/2] tpm: add securityfs support for TPM 2.0 firmware  event log Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-04 14:10 +0100

csiph-web