Re: [PATCH v7 2/2] tpm: add securityfs support for TPM 2.0 firmware event log

From	Nayna <nayna@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 2/2] tpm: add securityfs support for TPM 2.0 firmware event log
Date	2017-01-04 09:50 +0100
Message-ID	<sVPqF-2eb-5@gated-at.bofh.it> (permalink)
References	<sN51D-3yp-1@gated-at.bofh.it> <sN51D-3yp-3@gated-at.bofh.it> <sVj7r-52K-21@gated-at.bofh.it> <sVrRn-2Qs-9@gated-at.bofh.it> <sVxtL-70z-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 01/03/2017 07:03 PM, Jarkko Sakkinen wrote:
> On Tue, Jan 03, 2017 at 01:09:18PM +0530, Nayna wrote:
>>
>>
>> On 01/03/2017 03:42 AM, Jarkko Sakkinen wrote:
>>> On Sun, Dec 11, 2016 at 12:35:33AM -0500, Nayna Jain wrote:
>>>> Unlike the device driver support for TPM 1.2, the TPM 2.0 does
>>>> not support the securityfs pseudo files for displaying the
>>>> firmware event log.
>>>>
>>>> This patch enables support for providing the TPM 2.0 event log in
>>>> binary form. TPM 2.0 event log supports a crypto agile format that
>>>> records multiple digests, which is different from TPM 1.2. This
>>>> patch enables the tpm_bios_log_setup for TPM 2.0  and adds the
>>>> event log parser which understand the TPM 2.0 crypto agile format.
>>>>
>>>> Signed-off-by: Nayna Jain <nayna@linux.vnet.ibm.com>
>>>
>>> There is something fundamentally wrong in this commit.
>>>
>>> You must not allow this feature unless CONFIG_OF is set. It is the only
>>> interface where the supply path of the event log is well defined on
>>> platforms that include a TPM 2.0 chip.
>>
>> As per current implementation, if ACPI with TPM 2.0 doesn't support event
>> log, tpm_read_log_acpi() is expected to return rc and tpm_bios_log_setup
>> will not create securityfs. This is inline with our design for TPM 1.2 event
>> log.
>
> At minimum you must have a check for TPM_CHIP_FLAG_TPM2 in the beginning
> of tpm_read_log_acpi. It is wrong to even try to open TCPA in this case.

Sure, will add this check and return -ENODEV if check passes.

Thanks & Regards,
     - Nayna

>
> /Jarkko
>

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v7 2/2] tpm: add securityfs support for TPM 2.0 firmware  event log Nayna <nayna@linux.vnet.ibm.com> - 2017-01-04 09:50 +0100
  Re: [PATCH v7 2/2] tpm: add securityfs support for TPM 2.0 firmware  event log Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-04 14:10 +0100

csiph-web