Re: [PATCH 02/13] KVM: arm: fix gcc-4.5 build

From	Christoffer Dall <christoffer.dall@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 02/13] KVM: arm: fix gcc-4.5 build
Date	2017-01-04 11:40 +0100
Message-ID	<sVR98-3si-27@gated-at.bofh.it> (permalink)
References	<sOYp3-2rU-5@gated-at.bofh.it> <sOYp4-2rU-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Dec 16, 2016 at 11:56:23AM +0100, Arnd Bergmann wrote:
> Old gcc versions cannot used named initializers for anonymous
> unions, leading to a build failure here. This replaces the anonymous
> union with a named one, which allows us to build with at least gcc-4.3
> through 4.5. Versions 4.6 and higher are fine without this.
> 
> virt/kvm/arm/vgic/vgic-mmio-v2.c:295: error: unknown field 'read' specified in initializer
> virt/kvm/arm/vgic/vgic-mmio-v2.c:295: warning: missing braces around initializer
> virt/kvm/arm/vgic/vgic-mmio-v2.c:295: warning: (near initialization for 'vgic_v2_dist_registers[0].<anonymous>')
> virt/kvm/arm/vgic/vgic-mmio-v2.c:295: error: unknown field 'write' specified in initializer
> virt/kvm/arm/vgic/vgic-mmio-v2.c:298: error: unknown field 'read' specified in initializer
> 
> Fixes: 59c5ab40989a ("KVM: arm64: vgic-its: Introduce ITS emulation file with MMIO framework")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

If this series is moving ahead, I have no problems with this patch:

Acked-by: Christoffer Dall <christoffer.dall@linaro.org>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 02/13] KVM: arm: fix gcc-4.5 build Christoffer Dall <christoffer.dall@linaro.org> - 2017-01-04 11:40 +0100

csiph-web