Re: [PATCH] drm: nouveau: fix build when LEDS_CLASS=m

From	Daniel Vetter <daniel@ffwll.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drm: nouveau: fix build when LEDS_CLASS=m
Date	2017-01-04 09:50 +0100
Message-ID	<sVPqF-2eb-1@gated-at.bofh.it> (permalink)
References	<sUYFH-7mX-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Jan 01, 2017 at 04:20:53PM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix build errors in nouveau driver when CONFIG_LEDS_CLASS=m and
> CONFIG_DRM_NOUVEAU=y.
> If LEDS_CLASS is enabled, DRM_NOUVEAU is restricted to the same
> kconfig value as LEDS_CLASS.
> 
> drivers/built-in.o: In function `nouveau_do_suspend':
> nouveau_drm.c:(.text+0x2030b1): undefined reference to `nouveau_led_suspend'
> drivers/built-in.o: In function `nouveau_do_resume':
> nouveau_drm.c:(.text+0x2034ca): undefined reference to `nouveau_led_resume'
> drivers/built-in.o: In function `nouveau_drm_unload':
> nouveau_drm.c:(.text+0x203a15): undefined reference to `nouveau_led_fini'
> drivers/built-in.o: In function `nouveau_drm_load':
> nouveau_drm.c:(.text+0x204423): undefined reference to `nouveau_led_init'
> 
> BTW, this line in Kbuild:
> nouveau-$(CONFIG_LEDS_CLASS) += nouveau_led.o
> does nothing when CONFIG_LEDS_CLASS=m and CONFIG_DRM_NOUVEAU=y.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Cc: Martin Peres <martin.peres@free.fr>
> Cc: Ben Skeggs <bskeggs@redhat.com>

Thrown into drm-misc, thanks.
-Daniel

> ---
>  drivers/gpu/drm/nouveau/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- lnx-410-rc2.orig/drivers/gpu/drm/nouveau/Kconfig
> +++ lnx-410-rc2/drivers/gpu/drm/nouveau/Kconfig
> @@ -1,6 +1,7 @@
>  config DRM_NOUVEAU
>  	tristate "Nouveau (NVIDIA) cards"
>  	depends on DRM && PCI
> +	depends on LEDS_CLASS || LEDS_CLASS=n
>          select FW_LOADER
>  	select DRM_KMS_HELPER
>  	select DRM_TTM
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] drm: nouveau: fix build when LEDS_CLASS=m Daniel Vetter <daniel@ffwll.ch> - 2017-01-04 09:50 +0100
  Re: [PATCH] drm: nouveau: fix build when LEDS_CLASS=m Ilia Mirkin <imirkin@alum.mit.edu> - 2017-01-04 15:30 +0100
    Re: [PATCH] drm: nouveau: fix build when LEDS_CLASS=m Randy Dunlap <rdunlap@infradead.org> - 2017-01-05 04:00 +0100
      Re: [PATCH] drm: nouveau: fix build when LEDS_CLASS=m Randy Dunlap <rdunlap@infradead.org> - 2017-01-05 04:20 +0100
        Re: [PATCH] drm: nouveau: fix build when LEDS_CLASS=m Ilia Mirkin <imirkin@alum.mit.edu> - 2017-01-05 04:30 +0100
      Re: [PATCH] drm: nouveau: fix build when LEDS_CLASS=m Ilia Mirkin <imirkin@alum.mit.edu> - 2017-01-05 04:20 +0100
  Re: [PATCH] drm: nouveau: fix build when LEDS_CLASS=m Randy Dunlap <rdunlap@infradead.org> - 2017-01-04 23:30 +0100
    Re: [PATCH] drm: nouveau: fix build when LEDS_CLASS=m Daniel Vetter <daniel@ffwll.ch> - 2017-01-05 09:10 +0100
      Re: [PATCH] drm: nouveau: fix build when LEDS_CLASS=m Randy Dunlap <rdunlap@infradead.org> - 2017-01-05 17:10 +0100
        Re: [PATCH] drm: nouveau: fix build when LEDS_CLASS=m Jani Nikula <jani.nikula@linux.intel.com> - 2017-01-09 12:00 +0100

csiph-web