Re: [RESEND PATCH V3 4/4] gpio: pv88080: Add GPIO function support

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [RESEND PATCH V3 4/4] gpio: pv88080: Add GPIO function support
Date	2016-12-28 01:30 +0100
Message-ID	<sTahX-KT-5@gated-at.bofh.it> (permalink)
References	<sLgXf-6ls-5@gated-at.bofh.it> <sLgXf-6ls-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Dec 6, 2016 at 6:33 AM, Eric Jeong
<eric.jeong.opensource@diasemi.com> wrote:

> From: Eric Jeong <eric.jeong.opensource@diasemi.com>
>
> This patch adds support for PV88080 PMIC GPIOs.
> PV88080 has two configurable GPIOs.
>
> Kconfig and Makefile are updated to reflect support
> for PV88080 PMIC GPIO.
>
> Signed-off-by: Eric Jeong <eric.jeong.opensource@diasemi.com>

> +#include <linux/gpio.h>

Use

#include <linux/gpio/driver.h>

only.

> +#include <linux/mfd/pv88080.h>

I see this header is not yet upstream so I can't merge
this driver (else I would just correct the above and merge it).

With the oneliner change:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

I guess Lee needs to merge this with the MFD bits.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [RESEND PATCH V3 4/4] gpio: pv88080: Add GPIO function support Linus Walleij <linus.walleij@linaro.org> - 2016-12-28 01:30 +0100

csiph-web