Re: [RFC PATCH 4.10 1/6] crypto/sha256: Refactor the API so it can be used without shash

Path	csiph.com!feeder.erje.net!1.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 4.10 1/6] crypto/sha256: Refactor the API so it can be used without shash
Date	Mon, 26 Dec 2016 09:00:01 +0100
Message-ID	<sSyml-1OR-7@gated-at.bofh.it> (permalink)
References	<sRKfT-7Ww-3@gated-at.bofh.it> <sRKfT-7Ww-5@gated-at.bofh.it> <sRRU6-5K6-13@gated-at.bofh.it> <sRYLT-1yK-3@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	15
Organization	linux.* mail to news gateway
X-Original-Cc	Ard Biesheuvel <ard.biesheuvel@linaro.org>, Andy Lutomirski <luto@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, Netdev <netdev@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>, Linux Crypto Mailing List <linux-crypto@vger.kernel.org>, "Jason A. Donenfeld" <Jason@zx2c4.com>, Hannes Frederic Sowa <hannes@stressinduktion.org>, Alexei Starovoitov <alexei.starovoitov@gmail.com>, Eric Dumazet <edumazet@google.com>, Eric Biggers <ebiggers3@gmail.com>, Tom Herbert <tom@herbertland.com>, "David S. Miller" <davem@davemloft.net>
X-Original-Date	Mon, 26 Dec 2016 15:57:57 +0800
X-Original-Message-ID	<20161226075757.GA8916@gondor.apana.org.au>
X-Original-References	<cover.1482545792.git.luto@kernel.org> <942b91f25a63b22ec4946378a1fffe78d655cf18.1482545792.git.luto@kernel.org> <CAKv+Gu-UCqwchgbhg8VN4s=Yxk=PkjXG46NZo=8P4wAQtJ2TXw@mail.gmail.com> <CALCETrVbT_1=cdU1+a-+KbhoFqeT3XvbHjY0s_U7C5JVgiPx_Q@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1547273

Show key headers only | View raw

On Sat, Dec 24, 2016 at 09:57:53AM -0800, Andy Lutomirski wrote:
> 
> I actually do use incremental hashing later on.   BPF currently
> vmallocs() a big temporary buffer just so it can fill it and hash it.
> I change it to hash as it goes.

How much data is this supposed to hash on average? If it's a large
amount then perhaps using the existing crypto API would be a better
option than adding this.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Thread

[RFC PATCH 4.10 1/6] crypto/sha256: Refactor the API so it can be used without shash Andy Lutomirski <luto@kernel.org> - 2016-12-24 03:30 +0100
  Re: [RFC PATCH 4.10 1/6] crypto/sha256: Refactor the API so it can be  used without shash Andy Lutomirski <luto@amacapital.net> - 2016-12-24 03:30 +0100
  Re: [RFC PATCH 4.10 1/6] crypto/sha256: Refactor the API so it can be  used without shash Andy Lutomirski <luto@amacapital.net> - 2016-12-24 19:00 +0100
    Re: [RFC PATCH 4.10 1/6] crypto/sha256: Refactor the API so it can  be used without shash Herbert Xu <herbert@gondor.apana.org.au> - 2016-12-26 09:00 +0100
      Re: [RFC PATCH 4.10 1/6] crypto/sha256: Refactor the API so it can be  used without shash Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-12-26 19:00 +0100
        Re: [RFC PATCH 4.10 1/6] crypto/sha256: Refactor the API so it can be  used without shash Andy Lutomirski <luto@amacapital.net> - 2016-12-26 19:20 +0100
          Re: [RFC PATCH 4.10 1/6] crypto/sha256: Refactor the API so it can  be used without shash Herbert Xu <herbert@gondor.apana.org.au> - 2016-12-27 11:00 +0100
            Re: [RFC PATCH 4.10 1/6] crypto/sha256: Refactor the API so it can  be used without shash Daniel Borkmann <daniel@iogearbox.net> - 2016-12-27 15:20 +0100
              Re: [RFC PATCH 4.10 1/6] crypto/sha256: Refactor the API so it can be  used without shash Andy Lutomirski <luto@amacapital.net> - 2016-12-27 20:10 +0100

csiph-web