Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1547363

Re: [RFC PATCH 4.10 1/6] crypto/sha256: Refactor the API so it can be used without shash

From Ard Biesheuvel <ard.biesheuvel@linaro.org>
Newsgroups linux.kernel
Subject Re: [RFC PATCH 4.10 1/6] crypto/sha256: Refactor the API so it can be used without shash
Date 2016-12-26 19:00 +0100
Message-ID <sSHIZ-7O7-1@gated-at.bofh.it> (permalink)
References <sRKfT-7Ww-3@gated-at.bofh.it> <sRKfT-7Ww-5@gated-at.bofh.it> <sRRU6-5K6-13@gated-at.bofh.it> <sRYLT-1yK-3@gated-at.bofh.it> <sSyml-1OR-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 26 December 2016 at 07:57, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Sat, Dec 24, 2016 at 09:57:53AM -0800, Andy Lutomirski wrote:
>>
>> I actually do use incremental hashing later on.   BPF currently
>> vmallocs() a big temporary buffer just so it can fill it and hash it.
>> I change it to hash as it goes.
>
> How much data is this supposed to hash on average? If it's a large
> amount then perhaps using the existing crypto API would be a better
> option than adding this.
>

This is a good point actually: you didn't explain *why* BPF shouldn't
depend on the crypto API.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC PATCH 4.10 1/6] crypto/sha256: Refactor the API so it can be used without shash Andy Lutomirski <luto@kernel.org> - 2016-12-24 03:30 +0100
  Re: [RFC PATCH 4.10 1/6] crypto/sha256: Refactor the API so it can be  used without shash Andy Lutomirski <luto@amacapital.net> - 2016-12-24 03:30 +0100
  Re: [RFC PATCH 4.10 1/6] crypto/sha256: Refactor the API so it can be  used without shash Andy Lutomirski <luto@amacapital.net> - 2016-12-24 19:00 +0100
    Re: [RFC PATCH 4.10 1/6] crypto/sha256: Refactor the API so it can  be used without shash Herbert Xu <herbert@gondor.apana.org.au> - 2016-12-26 09:00 +0100
      Re: [RFC PATCH 4.10 1/6] crypto/sha256: Refactor the API so it can be  used without shash Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-12-26 19:00 +0100
        Re: [RFC PATCH 4.10 1/6] crypto/sha256: Refactor the API so it can be  used without shash Andy Lutomirski <luto@amacapital.net> - 2016-12-26 19:20 +0100
          Re: [RFC PATCH 4.10 1/6] crypto/sha256: Refactor the API so it can  be used without shash Herbert Xu <herbert@gondor.apana.org.au> - 2016-12-27 11:00 +0100
            Re: [RFC PATCH 4.10 1/6] crypto/sha256: Refactor the API so it can  be used without shash Daniel Borkmann <daniel@iogearbox.net> - 2016-12-27 15:20 +0100
              Re: [RFC PATCH 4.10 1/6] crypto/sha256: Refactor the API so it can be  used without shash Andy Lutomirski <luto@amacapital.net> - 2016-12-27 20:10 +0100

csiph-web