Re: [alsa-devel] [PATCH 2/2] ASoC: Intel: boards: Add Baytrail RT5660 machine driver

From	Shrirang Bagul <shrirang.bagul@canonical.com>
Newsgroups	linux.kernel
Subject	Re: [alsa-devel] [PATCH 2/2] ASoC: Intel: boards: Add Baytrail RT5660 machine driver
Date	2016-12-27 04:40 +0100
Message-ID	<sSQMh-5cb-9@gated-at.bofh.it> (permalink)
References	(1 earlier) <sQ6DU-8us-27@gated-at.bofh.it> <sQ8w2-1oA-25@gated-at.bofh.it> <sQ98J-1Te-9@gated-at.bofh.it> <sQ9ip-1WS-9@gated-at.bofh.it> <sSQMh-5cb-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, 2016-12-27 at 11:29 +0800, Shrirang Bagul wrote:
> On Mon, 2016-12-19 at 16:44 +0000, Mark Brown wrote:
> > On Mon, Dec 19, 2016 at 10:30:09AM -0600, Pierre-Louis Bossart wrote:
> > 
> > > All this code seems to be largely a copy-paste of the bytcr_rt5640 machine
> > > driver and the same comments would apply there. This patch did miss the
> > > last
> > 
> > Yes, there's a lot of room for cleanups in the existing code too (and of
> > course if there's such a large amount of cut'n'paste that implies that
> > there should be some code reuse going on).
> 
> Thank you for the review and valuable comments. Following the discussion so
> far,
> I feel the proper way would be to adapt bytcr_rt5660  machine driver to manage
> RT5660 codec.
typo, should be bytcr_rt5640
> > 
> > > correction merged by Mark to deal with errors "ASoC: Intel: bytcr_rt5640:
> > > fallback mechanism if MCLK is not enabled" and the same error handling
> > > would
> > > be needed.
> > 
> > There was a cut back version of it I thought?
> 
> Will try and include the MCLK fallback patch in ver. 2 of the patch.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] ASoC: Intel: boards: Add Baytrail RT5660 machine driver Shrirang Bagul <shrirang.bagul@canonical.com> - 2016-12-19 15:00 +0100
  Re: [PATCH 2/2] ASoC: Intel: boards: Add Baytrail RT5660 machine  driver Mark Brown <broonie@kernel.org> - 2016-12-19 17:00 +0100
    Re: [alsa-devel] [PATCH 2/2] ASoC: Intel: boards: Add Baytrail RT5660  machine driver Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> - 2016-12-19 17:40 +0100
      Re: [alsa-devel] [PATCH 2/2] ASoC: Intel: boards: Add Baytrail  RT5660 machine driver Mark Brown <broonie@kernel.org> - 2016-12-19 17:50 +0100
        Re: [alsa-devel] [PATCH 2/2] ASoC: Intel: boards: Add Baytrail  RT5660 machine driver Shrirang Bagul <shrirang.bagul@canonical.com> - 2016-12-27 04:40 +0100
          Re: [alsa-devel] [PATCH 2/2] ASoC: Intel: boards: Add Baytrail  RT5660 machine driver Shrirang Bagul <shrirang.bagul@canonical.com> - 2016-12-27 04:40 +0100

csiph-web