Re: [PATCH 1/2] ASoC: rt5660: Add ACPI support

From	Shrirang Bagul <shrirang.bagul@canonical.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] ASoC: rt5660: Add ACPI support
Date	2016-12-27 04:40 +0100
Message-ID	<sSQMh-5cb-3@gated-at.bofh.it> (permalink)
References	<sQ6DU-8us-29@gated-at.bofh.it> <sQ6DU-8us-37@gated-at.bofh.it> <sQ8mq-1lk-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, 2016-12-19 at 15:44 +0000, Mark Brown wrote:
> On Mon, Dec 19, 2016 at 09:51:46PM +0800, Shrirang Bagul wrote:
> 
> > +static const struct acpi_gpio_params audio_wake_intr_gpio = { 0, 0, false
> > };
> > +static const struct acpi_gpio_params lineout_mute_gpio = { 1, 0, true };
> 
> Can we please write these in a fashion more idiomatic for the kernel and
> useful for human readers with named struct fields?
Okay, will update in ver. 2 of the patch. Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] ASoC: Dell IoT Gateway audio support Shrirang Bagul <shrirang.bagul@canonical.com> - 2016-12-19 15:00 +0100
  [PATCH 1/2] ASoC: rt5660: Add ACPI support Shrirang Bagul <shrirang.bagul@canonical.com> - 2016-12-19 15:00 +0100
    Re: [PATCH 1/2] ASoC: rt5660: Add ACPI support Mark Brown <broonie@kernel.org> - 2016-12-19 16:50 +0100
      Re: [PATCH 1/2] ASoC: rt5660: Add ACPI support Shrirang Bagul <shrirang.bagul@canonical.com> - 2016-12-27 04:40 +0100

csiph-web