Re: [PATCH 03/15] hyperv: use standard bitops

From	Paolo Bonzini <pbonzini@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 03/15] hyperv: use standard bitops
Date	2016-12-22 13:40 +0100
Message-ID	<sRaP8-140-27@gated-at.bofh.it> (permalink)
References	<sQwoG-8wo-21@gated-at.bofh.it> <sQNSx-3fG-7@gated-at.bofh.it> <sQNSx-3fG-5@gated-at.bofh.it> <sRaP8-140-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 21/12/2016 14:23, Roman Kagan wrote:
> On Wed, Dec 21, 2016 at 01:00:44PM +0100, Olaf Hering wrote:
>> On Tue, Dec 20, Roman Kagan wrote:
>>
>> Reverting commit 22356585712d ("staging: hv: use sync_bitops when
>> interacting with the hypervisor") is save because .......
>>
>>> -		sync_set_bit(channel->monitor_bit,
>>> +		set_bit(channel->monitor_bit,
> 
> It isn't indeed.  I didn't realize there was a UP case where it made a
> difference, and failed to locate the commit where it changed.
> 
> I'll drop this part, thanks.

Perhaps the sync_bitops should be renamed to virt_bitops.  This would
match virt_* memory barriers and would make their usage much more obvious.

Paolo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 03/15] hyperv: use standard bitops Olaf Hering <olaf@aepfle.de> - 2016-12-21 13:10 +0100
  Re: [PATCH 03/15] hyperv: use standard bitops Paolo Bonzini <pbonzini@redhat.com> - 2016-12-22 13:40 +0100

csiph-web