Re: [PATCH] sched/fair: fix calc_cfs_shares fixed point arithmetics

From	Samuel Thibault <samuel.thibault@ens-lyon.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] sched/fair: fix calc_cfs_shares fixed point arithmetics
Date	2016-12-20 14:30 +0100
Message-ID	<sQsEp-675-9@gated-at.bofh.it> (permalink)
References	(3 earlier) <sQfxw-5WR-29@gated-at.bofh.it> <sQfHb-605-5@gated-at.bofh.it> <sQfHb-605-11@gated-at.bofh.it> <sQfQR-63A-9@gated-at.bofh.it> <sQsl3-60s-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Dietmar Eggemann, on Tue 20 Dec 2016 14:04:34 +0100, wrote:
> On 12/20/2016 12:45 AM, Samuel Thibault wrote:
> >Paul Turner, on Mon 19 Dec 2016 15:32:15 -0800, wrote:
> >>On Mon, Dec 19, 2016 at 3:29 PM, Samuel Thibault
> >><samuel.thibault@ens-lyon.org> wrote:
> >>>Paul Turner, on Mon 19 Dec 2016 15:26:19 -0800, wrote:
> 
> [...]
> 
> >>The MIN_SHARES you are seeing here is overloaded.
> >>In the unscaled case this needs to be MIN_SHARES, and in the scaled
> >>case, the subdivision of the scaled values must still be >=2.
> >
> >Ok, now I understand.  I have to say this overloading is confusing.
> >
> >Samuel
> 
> this had been already discussed back in August when I posted the original
> patch.

But that doesn't show up in the source code or git history.  One
shouldn't have to dig mailing lists to get code comments :)

Samuel

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] sched/fair: fix calc_cfs_shares fixed point arithmetics Paul Turner <pjt@kernel.org> - 2016-12-19 23:50 +0100
  Re: [PATCH] sched/fair: fix calc_cfs_shares fixed point arithmetics Samuel Thibault <samuel.thibault@ens-lyon.org> - 2016-12-20 00:10 +0100
    Re: [PATCH] sched/fair: fix calc_cfs_shares fixed point arithmetics Paul Turner <pjt@kernel.org> - 2016-12-20 00:30 +0100
      Re: [PATCH] sched/fair: fix calc_cfs_shares fixed point arithmetics Samuel Thibault <samuel.thibault@ens-lyon.org> - 2016-12-20 00:40 +0100
        Re: [PATCH] sched/fair: fix calc_cfs_shares fixed point arithmetics Paul Turner <pjt@kernel.org> - 2016-12-20 00:40 +0100
          Re: [PATCH] sched/fair: fix calc_cfs_shares fixed point arithmetics Samuel Thibault <samuel.thibault@ens-lyon.org> - 2016-12-20 00:50 +0100
            Re: [PATCH] sched/fair: fix calc_cfs_shares fixed point arithmetics Dietmar Eggemann <dietmar.eggemann@arm.com> - 2016-12-20 14:10 +0100
              Re: [PATCH] sched/fair: fix calc_cfs_shares fixed point arithmetics Peter Zijlstra <peterz@infradead.org> - 2016-12-20 14:20 +0100
              Re: [PATCH] sched/fair: fix calc_cfs_shares fixed point arithmetics Samuel Thibault <samuel.thibault@ens-lyon.org> - 2016-12-20 14:30 +0100

csiph-web