Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1545100

Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics data

Show all headers | View raw

On Tue 20-12-16 13:10:40, Mel Gorman wrote:
> On Tue, Dec 20, 2016 at 10:18:14AM +0100, Michal Hocko wrote:
> > On Mon 12-12-16 13:59:07, Jia He wrote:
> > > In commit b9f00e147f27 ("mm, page_alloc: reduce branches in
> > > zone_statistics"), it reconstructed codes to reduce the branch miss rate.
> > > Compared with the original logic, it assumed if !(flag & __GFP_OTHER_NODE)
> > >  z->node would not be equal to preferred_zone->node. That seems to be
> > > incorrect.
> > 
> > I am sorry but I have hard time following the changelog. It is clear
> > that you are trying to fix a missed NUMA_{HIT,OTHER} accounting
> > but it is not really clear when such thing happens. You are adding
> > preferred_zone->node check. preferred_zone is the first zone in the
> > requested zonelist. So for the most allocations it is a node from the
> > local node. But if something request an explicit numa node (without
> > __GFP_OTHER_NODE which would be the majority I suspect) then we could
> > indeed end up accounting that as a NUMA_MISS, NUMA_FOREIGN so the
> > referenced patch indeed caused an unintended change of accounting AFAIU.
> > 
> 
> This is a similar concern to what I had. If the preferred zone, which is
> the first valid usable zone, is not a "hit" for the statistics then I
> don't know what "hit" is meant to mean.

But the first valid usable zone is defined based on the requested numa
node. Unless the requested node is memoryless then we should have a hit,
no?

-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics data Jia He <hejianet@gmail.com> - 2016-12-12 07:00 +0100
  Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics  data Michal Hocko <mhocko@kernel.org> - 2016-12-20 10:20 +0100
    Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics  data Mel Gorman <mgorman@techsingularity.net> - 2016-12-20 14:20 +0100
      Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics  data Michal Hocko <mhocko@kernel.org> - 2016-12-20 14:30 +0100
        Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics  data Mel Gorman <mgorman@techsingularity.net> - 2016-12-20 15:30 +0100
          Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics  data Michal Hocko <mhocko@kernel.org> - 2016-12-20 15:40 +0100
            Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics  data Vlastimil Babka <vbabka@suse.cz> - 2016-12-20 15:50 +0100
            Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics  data Mel Gorman <mgorman@techsingularity.net> - 2016-12-20 16:10 +0100
              Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics  data Michal Hocko <mhocko@kernel.org> - 2016-12-21 09:00 +0100
          Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics  data Mel Gorman <mgorman@techsingularity.net> - 2016-12-20 15:50 +0100
    Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics  data Vlastimil Babka <vbabka@suse.cz> - 2016-12-20 16:20 +0100
    Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics  data hejianet <hejianet@gmail.com> - 2016-12-21 04:10 +0100
  Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics  data Mel Gorman <mgorman@techsingularity.net> - 2016-12-20 13:40 +0100
    Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics  data hejianet <hejianet@gmail.com> - 2016-12-21 04:10 +0100

csiph-web