Re: [PATCH V2 2/2] mm/memblock.c: check return value of memblock_reserve() in memblock_virt_alloc_internal()

From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2 2/2] mm/memblock.c: check return value of memblock_reserve() in memblock_virt_alloc_internal()
Date	2016-12-21 14:30 +0100
Message-ID	<sQP7X-40K-29@gated-at.bofh.it> (permalink)
References	(1 earlier) <sPKWJ-C5-13@gated-at.bofh.it> <sQ830-1eW-21@gated-at.bofh.it> <sQvLX-80A-19@gated-at.bofh.it> <sQJYB-xo-13@gated-at.bofh.it> <sQOYi-3Xt-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed 21-12-16 13:13:32, Wei Yang wrote:
> On Wed, Dec 21, 2016 at 08:51:16AM +0100, Michal Hocko wrote:
> >On Tue 20-12-16 16:48:23, Wei Yang wrote:
> >> On Mon, Dec 19, 2016 at 04:21:57PM +0100, Michal Hocko wrote:
> >> >On Sun 18-12-16 14:47:50, Wei Yang wrote:
> >> >> memblock_reserve() may fail in case there is not enough regions.
> >> >
> >> >Have you seen this happenning in the real setups or this is a by-review
> >> >driven change?
> >> 
> >> This is a by-review driven change.
> >> 
> >> >[...]
> >> >>  again:
> >> >>  	alloc = memblock_find_in_range_node(size, align, min_addr, max_addr,
> >> >>  					    nid, flags);
> >> >> -	if (alloc)
> >> >> +	if (alloc && !memblock_reserve(alloc, size))
> >> >>  		goto done;
> >
> >So how exactly does the reserve fail when memblock_find_in_range_node
> >found a suitable range for the given size?
> >
> 
> Even memblock_find_in_range_node() gets a suitable range, memblock_reserve()
> still could fail. And the case just happens when memblock can't resize.
> memblock_reserve() reserve a range by adding a range to memblock.reserved. In
> case the memblock.reserved is full and can't resize, this fails.

Sorry for being dense but what does it mean that the reserved will get
full? Also how probable is such a situation? Is it even real? In other
words does this fix a real or only a theoretical problem?

Anyway this all should be part of the changelog.
-- 
Michal Hocko
SUSE Labs

Thread

[PATCH V2 0/2] mm/memblock.c: fix potential bug and code refine Wei Yang <richard.weiyang@gmail.com> - 2016-12-18 15:50 +0100
  [PATCH V2 2/2] mm/memblock.c: check return value of memblock_reserve() in memblock_virt_alloc_internal() Wei Yang <richard.weiyang@gmail.com> - 2016-12-18 15:50 +0100
    Re: [PATCH V2 2/2] mm/memblock.c: check return value of  memblock_reserve() in memblock_virt_alloc_internal() Michal Hocko <mhocko@kernel.org> - 2016-12-19 16:30 +0100
      Re: [PATCH V2 2/2] mm/memblock.c: check return value of  memblock_reserve() in memblock_virt_alloc_internal() Wei Yang <richard.weiyang@gmail.com> - 2016-12-20 17:50 +0100
        Re: [PATCH V2 2/2] mm/memblock.c: check return value of  memblock_reserve() in memblock_virt_alloc_internal() Michal Hocko <mhocko@kernel.org> - 2016-12-21 09:00 +0100
          Re: [PATCH V2 2/2] mm/memblock.c: check return value of  memblock_reserve() in memblock_virt_alloc_internal() Wei Yang <richard.weiyang@gmail.com> - 2016-12-21 14:20 +0100
            Re: [PATCH V2 2/2] mm/memblock.c: check return value of  memblock_reserve() in memblock_virt_alloc_internal() Michal Hocko <mhocko@kernel.org> - 2016-12-21 14:30 +0100
              Re: [PATCH V2 2/2] mm/memblock.c: check return value of  memblock_reserve() in memblock_virt_alloc_internal() Wei Yang <richard.weiyang@gmail.com> - 2016-12-21 15:50 +0100
                Re: [PATCH V2 2/2] mm/memblock.c: check return value of  memblock_reserve() in memblock_virt_alloc_internal() Michal Hocko <mhocko@kernel.org> - 2016-12-21 16:00 +0100
  [PATCH V2 1/2] mm/memblock.c: trivial code refine in memblock_is_region_memory() Wei Yang <richard.weiyang@gmail.com> - 2016-12-18 15:50 +0100
    Re: [PATCH V2 1/2] mm/memblock.c: trivial code refine in  memblock_is_region_memory() Michal Hocko <mhocko@kernel.org> - 2016-12-19 16:20 +0100
      Re: [PATCH V2 1/2] mm/memblock.c: trivial code refine in  memblock_is_region_memory() Wei Yang <richard.weiyang@gmail.com> - 2016-12-20 17:40 +0100
        Re: [PATCH V2 1/2] mm/memblock.c: trivial code refine in  memblock_is_region_memory() Michal Hocko <mhocko@kernel.org> - 2016-12-21 08:50 +0100
          Re: [PATCH V2 1/2] mm/memblock.c: trivial code refine in  memblock_is_region_memory() Michal Hocko <mhocko@kernel.org> - 2016-12-21 13:50 +0100
            Re: [PATCH V2 1/2] mm/memblock.c: trivial code refine in  memblock_is_region_memory() Wei Yang <richard.weiyang@gmail.com> - 2016-12-21 14:20 +0100
          Re: [PATCH V2 1/2] mm/memblock.c: trivial code refine in  memblock_is_region_memory() Wei Yang <richard.weiyang@gmail.com> - 2016-12-21 13:50 +0100

csiph-web