Re: [GIT PULL] KVM fixes for 4.10 merge window

From	Paolo Bonzini <pbonzini@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [GIT PULL] KVM fixes for 4.10 merge window
Date	2016-12-17 09:30 +0100
Message-ID	<sPixr-7cV-5@gated-at.bofh.it> (permalink)
References	<sP41r-6cL-13@gated-at.bofh.it> <sP6FY-7TO-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> On Fri, Dec 16, 2016 at 8:57 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> >
> >   git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus
> 
> This piece-of-shit branch has obviously never been even compile-tested:
> 
>   arch/x86/kernel/kvm.c: In function ‘__kvm_vcpu_is_preempted’:
>   arch/x86/kernel/kvm.c:596:14: error: ‘struct kvm_steal_time’ has no
> member named ‘preempted’
> 
> where commit b94c3698b4b0 ("Revert "x86/kvm: Support the vCPU
> preemption check"") removed the "preempted" field from struct
> kvm_steal_time, but you left this in place:
> 
>   __visible bool __kvm_vcpu_is_preempted(int cpu)
>   {
>           struct kvm_steal_time *src = &per_cpu(steal_time, cpu);
> 
>           return !!src->preempted;
>   }
> 
> And no, that is not a merge artifact in my tree (although that
> function did come in from Ingo). That compile failure comes from your
> very own branch.

Yes, it does.  Well, to be honest I did test this (not just compile-test
it) but I didn't have KVM guest support turned on, only KVM host support.

Sorry, I'll resend it and make sure I do a "make allmodconfig" in the
future (and not send pull requests at 6 PM on Friday).

Paolo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[GIT PULL] KVM fixes for 4.10 merge window Paolo Bonzini <pbonzini@redhat.com> - 2016-12-16 18:00 +0100
  Re: [GIT PULL] KVM fixes for 4.10 merge window Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-16 20:50 +0100
    Re: [GIT PULL] KVM fixes for 4.10 merge window Pan Xinhui <xinhui@linux.vnet.ibm.com> - 2016-12-17 04:10 +0100
      Re: [GIT PULL] KVM fixes for 4.10 merge window Paolo Bonzini <pbonzini@redhat.com> - 2016-12-17 09:30 +0100
    Re: [GIT PULL] KVM fixes for 4.10 merge window Paolo Bonzini <pbonzini@redhat.com> - 2016-12-17 09:30 +0100

csiph-web