Re: [PATCH 1/8] extcon: axp288: Remove dependency on non-existing platform_data

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Chanwoo Choi <cw00.choi@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/8] extcon: axp288: Remove dependency on non-existing platform_data
Date	Mon, 19 Dec 2016 07:20:01 +0100
Message-ID	<sPZsJ-46s-1@gated-at.bofh.it> (permalink)
References	<sPZsJ-46s-3@gated-at.bofh.it> <sPTQl-tj-5@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
X-Auditid	cbfee61a-f79bd6d000000fc6-d3-585779c2b358
Content-Transfer-Encoding	8BIT
Organization	Samsung Electronics
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
X-Brightmail-Tracker	H4sIAAAAAAAAA+NgFprPIsWRmVeSWpSXmKPExsVy+t9jQd1DleERBus6hC3eHJ/OZHF51xw2 i9uNK9gcmD3e77vK5tG3ZRWjx+dNcgHMUW42GamJKalFCql5yfkpmXnptkqhIW66FkoKeYm5 qbZKEbq+IUFKCmWJOaVAnpEBGnBwDnAPVtK3S3DLeDhDo+A8Z0V7p34D4332LkZODgkBE4l/ BzcyQ9hiEhfurWfrYuTiEBKYxSixbdoLFpAEr4CgxI/J94BsDg5mAXmJI5eyQcLMAuoSk+Yt Yoaof8Ao8bv9BjtEvZbEk0MHwGwWAVWJxa9PM4HYbEDx/S9usIHY/AKKEld/PGYEmSkqECHR faISJCwiECDx81Q/O8R8BYlf9zaxgtjCAlES/au/M0Ls6mOUWPlgEthtnAKWEjfuXWWewCg4 C8mpsxBOnYXk1AWMzKsYJVILkguKk9JzDfNSy/WKE3OLS/PS9ZLzczcxgiPnmdQOxoO73A8x CnAwKvHwFrwPixBiTSwrrsw9xCjBwawkwitSHh4hxJuSWFmVWpQfX1Sak1p8iNEU6NeJzFKi yfnAqM4riTc0MTcxNzawMLe0NDFSEudtnP0sXEggPbEkNTs1tSC1CKaPiYNTqoFx3vPj1+b+ 38h8TeEx5+JlRl5aHJMUWveZnov5rezbIlxXN9WZdZ/bzhuiYkc/uItufmOgKhLVHFdi/dxt z7WkXXsPbVDLTDt10Dgrhs31h82dNTtez05rU3nweY8Io32n8opnsmIuM9nqjt+fFlu5Zuuu qD5FkbUHQr1VfQ7Hcd6JWi+/2eWBEktxRqKhFnNRcSIAaYXmRrICAAA=
X-Mtr	20000000000000000@CPGS
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	31
X-Original-Cc	linux-kernel@vger.kernel.org
X-Original-Date	Mon, 19 Dec 2016 15:10:09 +0900
X-Original-Message-ID	<585779C1.9080402@samsung.com>
X-Original-References	<CGME20161219001318epcas5p1884657998ce4dd35c8ef8094fe00904f@epcas5p1.samsung.com> <20161219001313.13402-1-hdegoede@redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1544327

Show key headers only | View raw

Hi Hans,

On 2016년 12월 19일 09:13, Hans de Goede wrote:
> When the extcon_axp288 driver was originally merged, it was merged with
> a dependency on some other driver providing platform data for it.
> 
> However such another driver was never merged, so the extcon_axp288 as
> merged upstream has never worked, its probe method simply always returns
> -ENODEV.
> 
> This commit drops the dependency on the pdata always being there, instead
> it treats not having pdata as the pdata having a NULL gpio_mux_control,
> something which the code was already prepared to handle.
> 
> Note that the code for controlling the mux_control gpio is left in place,
> as this may be necessary to allow the axp288 pmic to properly detect the
> charger type (instead of assuming 500mA max charge current) on some
> tablets. This will make it easier for future patches to add support for
> this gpio by getting the gpio info from somewhere.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/extcon/extcon-axp288.c | 25 ++++++++++---------------
>  1 file changed, 10 insertions(+), 15 deletions(-)

Looks good to me.
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>

-- 
Regards,
Chanwoo Choi

Thread

[PATCH 1/8] extcon: axp288: Remove dependency on non-existing platform_data Hans de Goede <hdegoede@redhat.com> - 2016-12-19 01:20 +0100
  [PATCH 4/8] extcon: axp288: Fix possibly reporting 2 cables in state true Hans de Goede <hdegoede@redhat.com> - 2016-12-19 01:20 +0100
    Re: [PATCH 4/8] extcon: axp288: Fix possibly reporting 2 cables in  state true Chanwoo Choi <cw00.choi@samsung.com> - 2016-12-19 07:30 +0100
  [PATCH 2/8] extcon: axp288: Remove usb_phy notification code Hans de Goede <hdegoede@redhat.com> - 2016-12-19 01:20 +0100
    Re: [PATCH 2/8] extcon: axp288: Remove usb_phy notification code Chanwoo Choi <cw00.choi@samsung.com> - 2016-12-19 08:00 +0100
  Re: [PATCH 1/8] extcon: axp288: Remove dependency on non-existing  platform_data Chanwoo Choi <cw00.choi@samsung.com> - 2016-12-19 07:20 +0100
    Re: [PATCH 1/8] extcon: axp288: Remove dependency on non-existing  platform_data Chanwoo Choi <cw00.choi@samsung.com> - 2016-12-19 08:00 +0100
      Re: [PATCH 1/8] extcon: axp288: Remove dependency on non-existing  platform_data Hans de Goede <hdegoede@redhat.com> - 2016-12-19 09:20 +0100
        Re: [PATCH 1/8] extcon: axp288: Remove dependency on non-existing  platform_data Chanwoo Choi <cw00.choi@samsung.com> - 2016-12-19 09:30 +0100

csiph-web