Re: [PATCH 3/8] extcon: axp288: Simplify axp288_handle_chrg_det_event

From	Chanwoo Choi <cw00.choi@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/8] extcon: axp288: Simplify axp288_handle_chrg_det_event
Date	2016-12-19 07:20 +0100
Message-ID	<sPZsJ-46s-17@gated-at.bofh.it> (permalink)
References	<sPTQl-tj-5@gated-at.bofh.it> <sPZsJ-46s-19@gated-at.bofh.it> <sPTQl-tj-11@gated-at.bofh.it>
Organization	Samsung Electronics

Show all headers | View raw

Hi Hans,

On 2016년 12월 19일 09:13, Hans de Goede wrote:
> axp288_handle_chrg_det_event only gets called on change interrupts
> (so not that often), extcon_set_state_sync() checks itself if there are
> any actual changes before notifying listeners, and gpiod_set_value is
> not really expensive either.
> 
> So we can simply always do both on each interrupt removing a bunch of
> somewhat magic looking code from axp288_handle_chrg_det_event.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/extcon/extcon-axp288.c | 37 ++++++++++++-------------------------
>  1 file changed, 12 insertions(+), 25 deletions(-)

Looks good to me.
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>

-- 
Regards,
Chanwoo Choi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/8] extcon: axp288: Simplify axp288_handle_chrg_det_event Hans de Goede <hdegoede@redhat.com> - 2016-12-19 01:20 +0100
  Re: [PATCH 3/8] extcon: axp288: Simplify axp288_handle_chrg_det_event Chanwoo Choi <cw00.choi@samsung.com> - 2016-12-19 07:20 +0100

csiph-web