Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1542233
| From | Hannes Frederic Sowa <hannes@stressinduktion.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function |
| Date | 2016-12-14 23:10 +0100 |
| Message-ID | <sOpUm-5Dh-31@gated-at.bofh.it> (permalink) |
| References | <sO93b-1Im-3@gated-at.bofh.it> <sOhap-6vv-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 14.12.2016 13:46, Jason A. Donenfeld wrote: > Hi David, > > On Wed, Dec 14, 2016 at 10:56 AM, David Laight <David.Laight@aculab.com> wrote: >> ... >>> +u64 siphash24(const u8 *data, size_t len, const u8 key[SIPHASH24_KEY_LEN]) >> ... >>> + u64 k0 = get_unaligned_le64(key); >>> + u64 k1 = get_unaligned_le64(key + sizeof(u64)); >> ... >>> + m = get_unaligned_le64(data); >> >> All these unaligned accesses are going to get expensive on architectures >> like sparc64. > > Yes, the unaligned accesses aren't pretty. Since in pretty much all > use cases thus far, the data can easily be made aligned, perhaps it > makes sense to create siphash24() and siphash24_unaligned(). Any > thoughts on doing something like that? I fear that the alignment requirement will be a source of bugs on 32 bit machines, where you cannot even simply take a well aligned struct on a stack and put it into the normal siphash(aligned) function without adding alignment annotations everywhere. Even blocks returned from kmalloc on 32 bit are not aligned to 64 bit. Can we do this a runtime check and just have one function (siphash) dealing with that? Bye, Hannes
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 1/4] siphash: add cryptographically secure hashtable function "Jason A. Donenfeld" <Jason@zx2c4.com> - 2016-12-14 05:10 +0100
Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-12-14 12:40 +0100
Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function "Jason A. Donenfeld" <Jason@zx2c4.com> - 2016-12-14 14:20 +0100
Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-12-14 16:20 +0100
Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function "Jason A. Donenfeld" <Jason@zx2c4.com> - 2016-12-14 20:50 +0100
Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function Herbert Xu <herbert@gondor.apana.org.au> - 2016-12-15 09:00 +0100
Re: [kernel-hardening] Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function Daniel Micay <danielmicay@gmail.com> - 2016-12-15 09:20 +0100
Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function "Jason A. Donenfeld" <Jason@zx2c4.com> - 2016-12-14 13:50 +0100
Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-12-14 23:10 +0100
Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function "Jason A. Donenfeld" <Jason@zx2c4.com> - 2016-12-15 00:40 +0100
Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-12-15 09:40 +0100
RE: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function David Laight <David.Laight@ACULAB.COM> - 2016-12-15 12:10 +0100
RE: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function David Laight <David.Laight@ACULAB.COM> - 2016-12-15 13:30 +0100
Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-12-15 14:00 +0100
RE: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function David Laight <David.Laight@ACULAB.COM> - 2016-12-15 15:00 +0100
Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-12-15 16:00 +0100
RE: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function David Laight <David.Laight@ACULAB.COM> - 2016-12-15 16:50 +0100
Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-12-15 17:00 +0100
Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function "Jason A. Donenfeld" <Jason@zx2c4.com> - 2016-12-15 20:00 +0100
Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-12-15 21:40 +0100
Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function "Jason A. Donenfeld" <Jason@zx2c4.com> - 2016-12-15 21:50 +0100
Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-12-15 22:20 +0100
Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-12-15 22:20 +0100
Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function Peter Zijlstra <peterz@infradead.org> - 2016-12-15 23:10 +0100
Re: [kernel-hardening] Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function "Jason A. Donenfeld" <Jason@zx2c4.com> - 2016-12-15 22:20 +0100
Re: [kernel-hardening] Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-15 22:20 +0100
Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function Peter Zijlstra <peterz@infradead.org> - 2016-12-15 22:20 +0100
Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-12-15 13:30 +0100
[PATCH v3 2/3] secure_seq: use siphash24 instead of md5_transform "Jason A. Donenfeld" <Jason@zx2c4.com> - 2016-12-14 19:50 +0100
Re: [PATCH v3 2/3] secure_seq: use siphash24 instead of md5_transform kbuild test robot <lkp@intel.com> - 2016-12-14 22:50 +0100
[PATCH v3 1/3] siphash: add cryptographically secure hashtable function "Jason A. Donenfeld" <Jason@zx2c4.com> - 2016-12-14 19:50 +0100
[PATCH v3 3/3] random: use siphash24 instead of md5 for get_random_int/long "Jason A. Donenfeld" <Jason@zx2c4.com> - 2016-12-14 19:50 +0100
Re: [PATCH v3 3/3] random: use siphash24 instead of md5 for get_random_int/long kbuild test robot <lkp@intel.com> - 2016-12-14 23:00 +0100
Re: [PATCH v3 3/3] random: use siphash24 instead of md5 for get_random_int/long kbuild test robot <lkp@intel.com> - 2016-12-14 23:10 +0100
RE: [PATCH v3 3/3] random: use siphash24 instead of md5 for get_random_int/long David Laight <David.Laight@ACULAB.COM> - 2016-12-15 11:20 +0100
Re: [PATCH v3 3/3] random: use siphash24 instead of md5 for get_random_int/long "Jason A. Donenfeld" <Jason@zx2c4.com> - 2016-12-15 20:00 +0100
Re: [PATCH v3 1/3] siphash: add cryptographically secure hashtable function Tom Herbert <tom@herbertland.com> - 2016-12-14 20:20 +0100
Re: [PATCH v3 1/3] siphash: add cryptographically secure hashtable function "Jason A. Donenfeld" <Jason@zx2c4.com> - 2016-12-14 20:40 +0100
Re: [PATCH v3 1/3] siphash: add cryptographically secure hashtable function "Jason A. Donenfeld" <Jason@zx2c4.com> - 2016-12-14 22:00 +0100
Re: [PATCH v3 1/3] siphash: add cryptographically secure hashtable function Tom Herbert <tom@herbertland.com> - 2016-12-14 22:40 +0100
Re: [PATCH v3 1/3] siphash: add cryptographically secure hashtable function "Jason A. Donenfeld" <Jason@zx2c4.com> - 2016-12-15 00:00 +0100
Re: [PATCH v3 1/3] siphash: add cryptographically secure hashtable function "Jason A. Donenfeld" <Jason@zx2c4.com> - 2016-12-15 00:20 +0100
Re: [PATCH v3 1/3] siphash: add cryptographically secure hashtable function Christian Kujau <lists@nerdbynature.de> - 2016-12-18 01:10 +0100
Re: [PATCH v3 1/3] siphash: add cryptographically secure hashtable function Tom Herbert <tom@herbertland.com> - 2016-12-15 00:20 +0100
Re: [PATCH v3 1/3] siphash: add cryptographically secure hashtable function "Jason A. Donenfeld" <Jason@zx2c4.com> - 2016-12-15 00:40 +0100
Re: [PATCH v3 1/3] siphash: add cryptographically secure hashtable function Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-15 01:30 +0100
RE: [PATCH v3 1/3] siphash: add cryptographically secure hashtable function David Laight <David.Laight@ACULAB.COM> - 2016-12-15 11:30 +0100
Re: [PATCH v3 1/3] siphash: add cryptographically secure hashtable function Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-15 00:40 +0100
Re: [PATCH v3 1/3] siphash: add cryptographically secure hashtable function kbuild test robot <lkp@intel.com> - 2016-12-14 22:20 +0100
Re: [PATCH v3 1/3] siphash: add cryptographically secure hashtable function "Jason A. Donenfeld" <Jason@zx2c4.com> - 2016-12-14 22:30 +0100
[PATCH v4 3/4] secure_seq: use siphash instead of md5_transform "Jason A. Donenfeld" <Jason@zx2c4.com> - 2016-12-15 02:50 +0100
[PATCH v4 2/4] siphash: add N[qd]word helpers "Jason A. Donenfeld" <Jason@zx2c4.com> - 2016-12-15 02:50 +0100
[PATCH v4 4/4] random: use siphash instead of MD5 for get_random_int/long "Jason A. Donenfeld" <Jason@zx2c4.com> - 2016-12-15 02:50 +0100
[PATCH v4 1/4] siphash: add cryptographically secure hashtable function "Jason A. Donenfeld" <Jason@zx2c4.com> - 2016-12-15 02:50 +0100
csiph-web