Re: [v2] net:ethernet:cavium:octeon:octeon_mgmt: Handle return NULL error from devm_ioremap

From	arvind Yadav <arvind.yadav.cs@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [v2] net:ethernet:cavium:octeon:octeon_mgmt: Handle return NULL error from devm_ioremap
Date	2016-12-14 20:10 +0100
Message-ID	<sOn69-2mQ-3@gated-at.bofh.it> (permalink)
References	(1 earlier) <sOma6-1ze-29@gated-at.bofh.it> <sOma6-1ze-27@gated-at.bofh.it> <sOmMN-1X4-9@gated-at.bofh.it> <sOmMN-1X4-7@gated-at.bofh.it> <sOmWt-229-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

As per your suggestion, I have change the subject.

Thanks

On Thursday 15 December 2016 12:24 AM, Florian Fainelli wrote:
> On 12/14/2016 10:39 AM, arvind Yadav wrote:
>> Hi David,
>>
>> I have gave my comment.
>>
>> Thanks
>> Arvind
>>
>> On Wednesday 14 December 2016 11:44 PM, David Daney wrote:
>>> On 12/14/2016 10:06 AM, arvind Yadav wrote:
>>>> Yes, I have seen this error. We have a device with very less memory.
>>>> Basically it's OMAP2 board. We have to port Android L on this.
>>>> It's has 3.10 kernel version. In this device, we were getting Page
>>>> allocation failure.
>>> This makes absolutely no sense to me.  OCTEON is a mips64 SoC with a
>>> ton of memory where ioremap can never fail, and it doesn't run
>>> Android, and you are talking about OMAP2.
>>            -I just gave as example where i have seen ioremap issue.
>> Please don't relate. I know, Now it will not fail.  ioremap will through
>> NULL on failure. We should catch this error. Even other driver of MIPS
>> soc is having same check. It's just check which will not impact any
>> functionality or performance of this driver. It will avoid NULL pointer
>> error. We know, if  function is returning any error. we should catch.
> Your patch subject should also be changed to insert spaces between
> semicolon, so this would be:
>
> net: ethernet: cavium: octeon: octeon_mgmt:

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[v2] net:ethernet:cavium:octeon:octeon_mgmt: Handle return NULL error from devm_ioremap Arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-12-14 17:30 +0100
  Re: [v2] net:ethernet:cavium:octeon:octeon_mgmt: Handle return NULL  error from devm_ioremap arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-12-14 19:10 +0100
    Re: [v2] net:ethernet:cavium:octeon:octeon_mgmt: Handle return NULL  error from devm_ioremap arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-12-14 19:50 +0100
      Re: [v2] net:ethernet:cavium:octeon:octeon_mgmt: Handle return NULL  error from devm_ioremap Florian Fainelli <f.fainelli@gmail.com> - 2016-12-14 20:00 +0100
        Re: [v2] net:ethernet:cavium:octeon:octeon_mgmt: Handle return NULL  error from devm_ioremap arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-12-14 20:10 +0100

csiph-web