Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1542027

[v2] net:ethernet:cavium:octeon:octeon_mgmt: Handle return NULL error from devm_ioremap

Show all headers | View raw

Here, If devm_ioremap will fail. It will return NULL.
Kernel can run into a NULL-pointer dereference.
This error check will avoid NULL pointer dereference.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/net/ethernet/cavium/octeon/octeon_mgmt.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c b/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
index 4ab404f..33c2fec 100644
--- a/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
+++ b/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
@@ -1479,6 +1479,12 @@ static int octeon_mgmt_probe(struct platform_device *pdev)
 	p->agl = (u64)devm_ioremap(&pdev->dev, p->agl_phys, p->agl_size);
 	p->agl_prt_ctl = (u64)devm_ioremap(&pdev->dev, p->agl_prt_ctl_phys,
 					   p->agl_prt_ctl_size);
+	if (!p->mix || !p->agl || !p->agl_prt_ctl) {
+		dev_err(&pdev->dev, "failed to map I/O memory\n");
+		result = -ENOMEM;
+		goto err;
+	}
+
 	spin_lock_init(&p->lock);
 
 	skb_queue_head_init(&p->tx_list);
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[v2] net:ethernet:cavium:octeon:octeon_mgmt: Handle return NULL error from devm_ioremap Arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-12-14 17:30 +0100
  Re: [v2] net:ethernet:cavium:octeon:octeon_mgmt: Handle return NULL  error from devm_ioremap arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-12-14 19:10 +0100
    Re: [v2] net:ethernet:cavium:octeon:octeon_mgmt: Handle return NULL  error from devm_ioremap arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-12-14 19:50 +0100
      Re: [v2] net:ethernet:cavium:octeon:octeon_mgmt: Handle return NULL  error from devm_ioremap Florian Fainelli <f.fainelli@gmail.com> - 2016-12-14 20:00 +0100
        Re: [v2] net:ethernet:cavium:octeon:octeon_mgmt: Handle return NULL  error from devm_ioremap arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-12-14 20:10 +0100

csiph-web