Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1543176

Re: [PATCH] printk: Remove no longer used second struct cont

Show all headers | View raw

On Thu, Dec 15, 2016 at 5:37 PM, Sergey Senozhatsky
<sergey.senozhatsky.work@gmail.com> wrote:
>
> basically I'm talking about a bunch of 80-cols fixups.

Please don't.

Nobody uses a vt100 terminal any more. The 80-column wrapping is
excessive, and makes things like "grep" not work as well.

No, we still don't want excessively long lines, but that's generally
mainly because

 (a) we don't want to have excessively _complicated_ lines

 (b) we don't want to have excessively deep indentation (so if line
length is due to 4+ levels of indentation, that's usually the primary
problem).

 (c) email quoting gets iffier and uglier, so short lines always are
preferred if possible

but in general, aside from those concerns, a long legible line is
generally preferred over just adding line breaks for the very
_occasional_ line.

At the 100-column mark you almost have to break, because at that point
people may start to be actually limited by their displays, but 80
columns generally isn't it.

In fact, I thought we already upped the check-patch limit to 100?

              Linus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] printk: Remove no longer used second struct cont Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-15 14:30 +0100
  Re: [PATCH] printk: Remove no longer used second struct cont Petr Mladek <pmladek@suse.com> - 2016-12-15 17:30 +0100
    Re: [PATCH] printk: Remove no longer used second struct cont Joe Perches <joe@perches.com> - 2016-12-16 02:50 +0100
      Re: [PATCH] printk: Remove no longer used second struct cont Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-12-16 03:00 +0100
    Re: [PATCH] printk: Remove no longer used second struct cont Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-12-16 02:50 +0100
      Re: [PATCH] printk: Remove no longer used second struct cont Joe Perches <joe@perches.com> - 2016-12-16 03:00 +0100
        Re: [PATCH] printk: Remove no longer used second struct cont Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-16 03:20 +0100
          Re: [PATCH] printk: Remove no longer used second struct cont Joe Perches <joe@perches.com> - 2016-12-16 03:40 +0100
            Re: [PATCH] printk: Remove no longer used second struct cont Junio C Hamano <gitster@pobox.com> - 2016-12-16 06:10 +0100
              Re: [PATCH] printk: Remove no longer used second struct cont Joe Perches <joe@perches.com> - 2016-12-16 07:10 +0100
      Re: [PATCH] printk: Remove no longer used second struct cont Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-16 03:00 +0100
        Re: [PATCH] printk: Remove no longer used second struct cont Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-12-16 03:10 +0100
        Re: [PATCH] printk: Remove no longer used second struct cont Scott Matheina <scott@matheina.com> - 2016-12-18 20:30 +0100

csiph-web