Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1543167

Re: [PATCH] printk: Remove no longer used second struct cont

Show all headers | View raw

On Fri, 2016-12-16 at 10:37 +0900, Sergey Senozhatsky wrote:
> On (12/15/16 17:23), Petr Mladek wrote:
> > On Thu 2016-12-15 13:53:58, Geert Uytterhoeven wrote:
> > > If CONFIG_PRINTK=n:
> > > 
> > >     kernel/printk/printk.c:1893: warning: ‘cont’ defined but not used
> > > 
> > > Note that there are actually two different struct cont definitions and
> > > objects: the first one is used if CONFIG_PRINTK=y, the second one became
> > > unused by removing console_cont_flush().
> > > 
> > > Fixes: 5c2992ee7fd8a29d ("printk: remove console flushing special cases for partial buffered lines")
> > 
> > Great catch. It seems that nobody tried the build without CONFIG_PRINTK
> > at that time.
> 
> ok... since the patch is a cosmetic tweak... can we add several more
> cosmetic changes to it? yes, I know, N things in one patch is "a bad thing",
> but those extra changes don't deserve to be in a separate patch.
> 
> basically I'm talking about a bunch of 80-cols fixups.
> if it's irrelevant then feel free to ignore it.

While it might be nice to do some 80 column wrapping,
the most common wrap style is to the open parenthesis.

I'd also like to split up printk.c into a bunch of
smaller, more logically self-contained files eventually.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] printk: Remove no longer used second struct cont Geert Uytterhoeven <geert@linux-m68k.org> - 2016-12-15 14:30 +0100
  Re: [PATCH] printk: Remove no longer used second struct cont Petr Mladek <pmladek@suse.com> - 2016-12-15 17:30 +0100
    Re: [PATCH] printk: Remove no longer used second struct cont Joe Perches <joe@perches.com> - 2016-12-16 02:50 +0100
      Re: [PATCH] printk: Remove no longer used second struct cont Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-12-16 03:00 +0100
    Re: [PATCH] printk: Remove no longer used second struct cont Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-12-16 02:50 +0100
      Re: [PATCH] printk: Remove no longer used second struct cont Joe Perches <joe@perches.com> - 2016-12-16 03:00 +0100
        Re: [PATCH] printk: Remove no longer used second struct cont Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-16 03:20 +0100
          Re: [PATCH] printk: Remove no longer used second struct cont Joe Perches <joe@perches.com> - 2016-12-16 03:40 +0100
            Re: [PATCH] printk: Remove no longer used second struct cont Junio C Hamano <gitster@pobox.com> - 2016-12-16 06:10 +0100
              Re: [PATCH] printk: Remove no longer used second struct cont Joe Perches <joe@perches.com> - 2016-12-16 07:10 +0100
      Re: [PATCH] printk: Remove no longer used second struct cont Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-16 03:00 +0100
        Re: [PATCH] printk: Remove no longer used second struct cont Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-12-16 03:10 +0100
        Re: [PATCH] printk: Remove no longer used second struct cont Scott Matheina <scott@matheina.com> - 2016-12-18 20:30 +0100

csiph-web