Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1542841

Re: [RFC/PATCH] tracing: show total NMI time in hwlat tracer

From Namhyung Kim <namhyung@kernel.org>
Newsgroups linux.kernel
Subject Re: [RFC/PATCH] tracing: show total NMI time in hwlat tracer
Date 2016-12-15 16:50 +0100
Message-ID <sOGsa-7xD-13@gated-at.bofh.it> (permalink)
References <sOkrD-9J-13@gated-at.bofh.it> <sOkrD-9J-15@gated-at.bofh.it> <sOkrD-9J-11@gated-at.bofh.it> <sOGiu-7uh-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Fri, Dec 16, 2016 at 12:32 AM, Namhyung Kim <namhyung@kernel.org> wrote:
> On Wed, Dec 14, 2016 at 11:17:16AM -0500, Steven Rostedt wrote:
>> @@ -203,8 +212,13 @@ static int get_sample(void)
>>                       }
>>                       if (diff > outer_sample)
>>                               outer_sample = diff;
>> +
>> +                     diff = nmi_t1 - last_nmi;
>
> It these are time_type, it should use time_to_us() instead.

Oh, I meant "time_to_us(time_sub(nmi_t1, last_nmi))".

Thanks,
Namhyung


>
>> +                     if (diff > nmi_sample)
>> +                             nmi_sample = diff;
>>               }
>>               last_t2 = t2;
>> +             last_nmi = nmi_t2;
>>
>>               total = time_to_us(time_sub(t2, start)); /* sample width */
>>
>> @@ -227,6 +241,10 @@ static int get_sample(void)
>>               if (diff > sample)
>>                       sample = diff; /* only want highest value */
>>
>> +             diff = nmi_t2 - nmi_t1;
>> +             if (diff > nmi_sample)
>> +                     nmi_sample = diff;
>> +
>>       } while (total <= hwlat_data.sample_width);
>>
>>       barrier(); /* finish the above in the view for NMIs */

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [RFC/PATCH] tracing: show total NMI time in hwlat tracer Steven Rostedt <rostedt@goodmis.org> - 2016-12-14 17:20 +0100
  Re: [RFC/PATCH] tracing: show total NMI time in hwlat tracer Namhyung Kim <namhyung@kernel.org> - 2016-12-15 16:40 +0100
    Re: [RFC/PATCH] tracing: show total NMI time in hwlat tracer Namhyung Kim <namhyung@kernel.org> - 2016-12-15 16:50 +0100
  Re: [RFC/PATCH] tracing: show total NMI time in hwlat tracer Namhyung Kim <namhyung@kernel.org> - 2016-12-16 01:30 +0100

csiph-web