Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1541530

Re: [PATCH 5/5] Documentation: fsl-quadspi: Add fsl, ls1012a-qspi compatible string

Path csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From Rob Herring <robh@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 5/5] Documentation: fsl-quadspi: Add fsl, ls1012a-qspi compatible string
Date Tue, 13 Dec 2016 22:20:01 +0100
Message-ID <sO2Ep-6bg-11@gated-at.bofh.it> (permalink)
References <sNCgV-72u-3@gated-at.bofh.it> <sNCAh-796-13@gated-at.bofh.it> <sNCAh-796-11@gated-at.bofh.it> <sNXbH-2Pt-7@gated-at.bofh.it>
X-Gm-Message-State AKaTC00aAvfhkU2vx1kl3Uy7bgdQa9kk19wzsEzbpiuHIjxbx8Cg1OUwqctozqYvi7ZYHZsWFc1NWOlYO9N92Q==
X-Received by 10.13.235.11 with SMTP id u11mr95036717ywe.10.1481663663558; Tue, 13 Dec 2016 13:14:23 -0800 (PST)
MIME-Version 1.0
X-Gmail-Original-Message-ID <CAL_Jsq+jp_2m7D=Hv6TRa+1nQZhPis-0MPK5kOAWge_7RvN4Qg@mail.gmail.com>
Content-Type text/plain; charset=UTF-8
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 26
Organization linux.* mail to news gateway
X-Original-Cc Yuan Yao <yao.yuan@freescale.com>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "mark.rutland@arm.com" <mark.rutland@arm.com>, "computersforpeace@gmail.com" <computersforpeace@gmail.com>, "dwmw2@infradead.org" <dwmw2@infradead.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
X-Original-Date Tue, 13 Dec 2016 15:14:03 -0600
X-Original-Message-ID <CAL_Jsq+jp_2m7D=Hv6TRa+1nQZhPis-0MPK5kOAWge_7RvN4Qg@mail.gmail.com>
X-Original-References <1481188984-43683-1-git-send-email-yao.yuan@freescale.com> <1481188984-43683-6-git-send-email-yao.yuan@freescale.com> <20161212170948.fq7v5lva4kgt6hly@rob-hp-laptop> <DB6PR0402MB2902DADEB4E6D06418AD311F899B0@DB6PR0402MB2902.eurprd04.prod.outlook.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1541530

Show key headers only | View raw


On Mon, Dec 12, 2016 at 8:47 PM, Yao Yuan <yao.yuan@nxp.com> wrote:
> On Thu, Dec 13, 2016 at 05:23:02PM +0800, Rob Herring wrote:
>> On Thu, Dec 08, 2016 at 05:23:04PM +0800, Yuan Yao wrote:
>> > From: Yuan Yao <yao.yuan@nxp.com>
>>
>> Same problem in this subject too.
>>
>> >
>> > new compatible string: "fsl,ls1012a-qspi".
>> >
>> > Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
>> > ---
>> >  Documentation/devicetree/bindings/mtd/fsl-quadspi.txt | 1 +
>> >  1 file changed, 1 insertion(+)
>>
>> Acked-by: Rob Herring <robh@kernel.org>
>
> Thanks for your review.
> And do you have any suggestion for this subject?

The problem is you have a space in the compatible string: "fsl,
ls1012a-qspi" rather than "fsl,ls1012a-qspi"

Also, I prefer "dt/bindings: " as the beginning of binding patch subjects.

Rob

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH 5/5] Documentation: fsl-quadspi: Add fsl, ls1012a-qspi  compatible string Rob Herring <robh@kernel.org> - 2016-12-12 18:30 +0100
  RE: [PATCH 5/5] Documentation: fsl-quadspi: Add fsl, ls1012a-qspi  compatible string Yao Yuan <yao.yuan@nxp.com> - 2016-12-13 16:30 +0100
    Re: [PATCH 5/5] Documentation: fsl-quadspi: Add fsl, ls1012a-qspi  compatible string Rob Herring <robh@kernel.org> - 2016-12-13 22:20 +0100
      RE: [PATCH 5/5] Documentation: fsl-quadspi: Add fsl, ls1012a-qspi  compatible string Yao Yuan <yao.yuan@nxp.com> - 2016-12-14 09:00 +0100

csiph-web