Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1540234
| From | Benjamin Tissoires <benjamin.tissoires@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support |
| Date | 2016-12-12 11:10 +0100 |
| Message-ID | <sNvIv-30q-55@gated-at.bofh.it> (permalink) |
| References | (5 earlier) <sM9Al-8ha-15@gated-at.bofh.it> <sM9K2-8la-1@gated-at.bofh.it> <sMuv7-4qd-11@gated-at.bofh.it> <sMuY9-4Pn-5@gated-at.bofh.it> <sNuCK-294-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Dec 12 2016 or thereabouts, Jiri Kosina wrote:
> Given the timing (merge window being open) and given then NACK given by
> Rob, I've now unapplied the patches (the for-4.10/i2c-hid branch is now
> obsolete, and has been superseded by for-4.10/i2c-hid-nopower).
>
> However, this is mostly done in order to provide more time for discussion;
> I still disagree with the reasoning behind the NACK.
>
To hopefully make things going forward a little bit, I was wondering
over the week-end if we should not solve this particular issue by adding
an intermediate platform DT node:
instead of having:
---
i2c-hid-dev@2c {
compatible = "hid-over-i2c";
reg = <0x2c>;
hid-descr-addr = <0x0020>;
interrupt-parent = <&gpx3>;
interrupts = <3 2>;
vdd-supply = <sth>;
init-delay-ms = <100>;
};
---
we would have:
---
platform-i2c-hid@01 {
compatible = "very-special-board-that-needs-firmware-quirks-and-delay-of-100ms";
vdd-supply = <sth>;
i2c-hid-dev@2c {
compatible = "hid-over-i2c";
reg = <0x2c>;
hid-descr-addr = <0x0020>;
interrupt-parent = <&gpx3>;
interrupts = <3 2>;
};
};
---
If I am not wrong, the platform device should be initialized before
i2c-hid get called, which allows to setup properly the vdd supply.
On resume/suspend, the tree should be respected and we should be able to
enable/disable power in the same fashion this patch provides.
We could then extend this platform device at will without tinkering in
i2c-hid and we could also handle the GPIOs, reset or whatever is
required in the future through compatibles.
Thoughts? yes? no? bullshit?
Cheers,
Benjamin
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Brian Norris <briannorris@chromium.org> - 2016-12-01 02:30 +0100
[PATCH v2 2/2] HID: i2c-hid: support Wacom digitizer + regulator Brian Norris <briannorris@chromium.org> - 2016-12-01 02:30 +0100
Re: [PATCH v2 2/2] HID: i2c-hid: support Wacom digitizer + regulator Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-12-01 15:50 +0100
Re: [PATCH v2 2/2] HID: i2c-hid: support Wacom digitizer + regulator Brian Norris <briannorris@chromium.org> - 2016-12-01 18:40 +0100
Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-12-01 15:40 +0100
Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Brian Norris <briannorris@chromium.org> - 2016-12-01 18:30 +0100
Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Rob Herring <robh@kernel.org> - 2016-12-06 01:00 +0100
Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-12-06 01:40 +0100
Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-12-06 09:50 +0100
Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Rob Herring <robh@kernel.org> - 2016-12-06 16:00 +0100
Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Doug Anderson <dianders@chromium.org> - 2016-12-06 17:20 +0100
Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-12-08 16:50 +0100
Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Rob Herring <robh@kernel.org> - 2016-12-08 17:10 +0100
Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-12-08 17:20 +0100
Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Rob Herring <robh@kernel.org> - 2016-12-08 17:30 +0100
Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-12-08 19:20 +0100
Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Rob Herring <robh@kernel.org> - 2016-12-09 15:40 +0100
Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Jiri Kosina <jikos@kernel.org> - 2016-12-09 15:40 +0100
Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Rob Herring <robh@kernel.org> - 2016-12-09 16:10 +0100
Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Doug Anderson <dianders@chromium.org> - 2016-12-09 17:20 +0100
Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Jiri Kosina <jikos@kernel.org> - 2016-12-12 10:00 +0100
Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-12-12 11:10 +0100
Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Rob Herring <robh@kernel.org> - 2016-12-12 15:50 +0100
Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Brian Norris <briannorris@chromium.org> - 2016-12-12 19:40 +0100
Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Rob Herring <robh@kernel.org> - 2016-12-13 23:20 +0100
Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Rob Herring <robh@kernel.org> - 2016-12-08 17:10 +0100
Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Doug Anderson <dianders@chromium.org> - 2016-12-09 17:10 +0100
Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Rob Herring <robh@kernel.org> - 2016-12-09 18:50 +0100
Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Rob Herring <robh@kernel.org> - 2016-12-06 00:50 +0100
Re: [PATCH v2 1/2] devicetree: i2c-hid: Add Wacom digitizer + regulator support Brian Norris <briannorris@chromium.org> - 2016-12-06 01:00 +0100
csiph-web