Re: [PATCH 08/10] vsock/virtio: mark an internal function static

From	Jason Wang <jasowang@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 08/10] vsock/virtio: mark an internal function static
Date	2016-12-12 03:00 +0100
Message-ID	<sNo4i-6w8-7@gated-at.bofh.it> (permalink)
References	<sLqad-3UD-31@gated-at.bofh.it> <sLqad-3UD-29@gated-at.bofh.it> <sLC1H-3sn-3@gated-at.bofh.it> <sM7RT-7ch-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 2016年12月08日 22:25, Michael S. Tsirkin wrote:
> On Wed, Dec 07, 2016 at 12:21:22PM +0800, Jason Wang wrote:
>>
>> On 2016年12月06日 23:41, Michael S. Tsirkin wrote:
>>> virtio_transport_alloc_pkt is only used locally, make it static.
>>>
>>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>>> ---
>>>    net/vmw_vsock/virtio_transport_common.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c
>>> index a53b3a1..6120384 100644
>>> --- a/net/vmw_vsock/virtio_transport_common.c
>>> +++ b/net/vmw_vsock/virtio_transport_common.c
>>> @@ -32,7 +32,7 @@ static const struct virtio_transport *virtio_transport_get_ops(void)
>>>    	return container_of(t, struct virtio_transport, transport);
>>>    }
>>> -struct virtio_vsock_pkt *
>>> +static struct virtio_vsock_pkt *
>>>    virtio_transport_alloc_pkt(struct virtio_vsock_pkt_info *info,
>>>    			   size_t len,
>>>    			   u32 src_cid,
>> Git grep shows it was used by tracing.
> True but trace_virtio_transport_alloc_pkt is also local to
> virtio_transport_common.c
>

I see, so let's remove the EXPORT_SYMBOL_GPL() too?

Thread

[PATCH 08/10] vsock/virtio: mark an internal function static "Michael S. Tsirkin" <mst@redhat.com> - 2016-12-06 16:50 +0100
  Re: [PATCH 08/10] vsock/virtio: mark an internal function static Jason Wang <jasowang@redhat.com> - 2016-12-07 05:30 +0100
    Re: [PATCH 08/10] vsock/virtio: mark an internal function static "Michael S. Tsirkin" <mst@redhat.com> - 2016-12-08 15:30 +0100
      Re: [PATCH 08/10] vsock/virtio: mark an internal function static Jason Wang <jasowang@redhat.com> - 2016-12-12 03:00 +0100
  Re: [PATCH 08/10] vsock/virtio: mark an internal function static Stefan Hajnoczi <stefanha@redhat.com> - 2016-12-07 15:20 +0100

csiph-web