Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1541092

Re: [PATCH RFC] [media] s5k6aa: set usleep_range greater 0

Show all headers | View raw

Hi Sylwester,

On Tuesday 13 Dec 2016 13:38:52 Sylwester Nawrocki wrote:
> On 12/13/2016 02:58 AM, Nicholas Mc Guire wrote:
> > As this is not in atomic context and it does not seem like a critical
> > timing setting a range of 1ms allows the timer subsystem to optimize
> > the hrtimer here.
> > 
> > Fixes: commit bfa8dd3a0524 ("[media] v4l: Add v4l2 subdev driver for
> > S5K6AAFX sensor") Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> > ---
> 
> Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> 
> I'm not sure the "Fixes" tag is needed here.
> 
> > Patch is against 4.9.0 (localversion-next is next-20161212)
> 
> Ideally patches for the media subsystem should be normally based on
> master branch of the media tree (git://linuxtv.org/media_tree.git).

As pointed out by Ian Arkver, the datasheet states the delay should be >50µs. 
Would it make sense to reduce the sleep duration to (3000, 4000) for instance 
(or possibly even lower), instead of increasing it ?

-- 
Regards,

Laurent Pinchart

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RFC] [media] s5k6aa: set usleep_range greater 0 Nicholas Mc Guire <hofrat@osadl.org> - 2016-12-13 03:00 +0100
  Re: [PATCH RFC] [media] s5k6aa: set usleep_range greater 0 Sakari Ailus <sakari.ailus@iki.fi> - 2016-12-13 10:50 +0100
    Re: [PATCH RFC] [media] s5k6aa: set usleep_range greater 0 Ian Arkver <ian.arkver.dev@gmail.com> - 2016-12-13 11:20 +0100
      Re: [PATCH RFC] [media] s5k6aa: set usleep_range greater 0 Sakari Ailus <sakari.ailus@iki.fi> - 2016-12-13 12:00 +0100
  Re: [PATCH RFC] [media] s5k6aa: set usleep_range greater 0 Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-12-13 13:40 +0100
    Re: [PATCH RFC] [media] s5k6aa: set usleep_range greater 0 Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-12-13 15:10 +0100
      Re: [PATCH RFC] [media] s5k6aa: set usleep_range greater 0 Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-12-13 16:00 +0100
        Re: [PATCH RFC] [media] s5k6aa: set usleep_range greater 0 Nicholas Mc Guire <der.herr@hofr.at> - 2016-12-15 02:20 +0100
          Re: [PATCH RFC] [media] s5k6aa: set usleep_range greater 0 Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-12-15 18:50 +0100

csiph-web