Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1540960

Re: [PATCH RFC] [media] s5k6aa: set usleep_range greater 0

Show all headers | View raw

On 13/12/16 09:43, Sakari Ailus wrote:
> Hi Nicholas,
>
> On Tue, Dec 13, 2016 at 02:58:02AM +0100, Nicholas Mc Guire wrote:
>> As this is not in atomic context and it does not seem like a critical
>> timing setting a range of 1ms allows the timer subsystem to optimize
>> the hrtimer here.
> I'd suggest not to. These delays are often directly visible to the user in
> use cases where attention is indeed paid to milliseconds.
>
> The same applies to register accesses. An delay of 0 to 100 µs isn't much as
> such, but when you multiply that with the number of accesses it begins to
> add up.
>
Data sheet for this device [1] says STBYN deassertion to RSTN 
deassertion should be >50us, though this is actually referenced to MCLK 
startup. See Figure 36, Power-Up Sequence, page 42.

I think the usleep range here could be greatly reduced and opened up to 
allow hr timer tweaks if desired.

[1] http://www.bdtic.com/DataSheet/SAMSUNG/S5K6AAFX13.pdf

Regards,
Ian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RFC] [media] s5k6aa: set usleep_range greater 0 Nicholas Mc Guire <hofrat@osadl.org> - 2016-12-13 03:00 +0100
  Re: [PATCH RFC] [media] s5k6aa: set usleep_range greater 0 Sakari Ailus <sakari.ailus@iki.fi> - 2016-12-13 10:50 +0100
    Re: [PATCH RFC] [media] s5k6aa: set usleep_range greater 0 Ian Arkver <ian.arkver.dev@gmail.com> - 2016-12-13 11:20 +0100
      Re: [PATCH RFC] [media] s5k6aa: set usleep_range greater 0 Sakari Ailus <sakari.ailus@iki.fi> - 2016-12-13 12:00 +0100
  Re: [PATCH RFC] [media] s5k6aa: set usleep_range greater 0 Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-12-13 13:40 +0100
    Re: [PATCH RFC] [media] s5k6aa: set usleep_range greater 0 Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-12-13 15:10 +0100
      Re: [PATCH RFC] [media] s5k6aa: set usleep_range greater 0 Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-12-13 16:00 +0100
        Re: [PATCH RFC] [media] s5k6aa: set usleep_range greater 0 Nicholas Mc Guire <der.herr@hofr.at> - 2016-12-15 02:20 +0100
          Re: [PATCH RFC] [media] s5k6aa: set usleep_range greater 0 Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-12-15 18:50 +0100

csiph-web