Re: [PATCH 1/2] mm/thp/pagecache: Only withdraw page table after a successful deposit

From	"Kirill A. Shutemov" <kirill@shutemov.name>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] mm/thp/pagecache: Only withdraw page table after a successful deposit
Date	2016-12-12 22:10 +0100
Message-ID	<sNG1c-R8-29@gated-at.bofh.it> (permalink)
References	<sNBNU-6Du-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Dec 12, 2016 at 10:04:27PM +0530, Aneesh Kumar K.V wrote:
> The current code wrongly called withdraw in the error path. But we
> haven't depoisted the page table yet in the only error path in that
> function. So for now remove that withdraw completely. If we take
> that "out:" branch, we should have vmf->prealloc_pte already pointing
> to the allocated page table.
> 
> Fixes: "mm: THP page cache support for ppc64"
> 
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>

Reported-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

-- 
 Kirill A. Shutemov

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] mm/thp/pagecache: Only withdraw page table after a successful deposit "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2016-12-12 17:40 +0100
  [PATCH 2/2] mm/thp/pagecache/collapse: Free the pte page table on collapse for thp page cache. "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2016-12-12 17:40 +0100
    Re: [PATCH 2/2] mm/thp/pagecache/collapse: Free the pte page table  on collapse for thp page cache. "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-12-12 22:10 +0100
  Re: [PATCH 1/2] mm/thp/pagecache: Only withdraw page table after a  successful deposit "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-12-12 22:10 +0100

csiph-web