Path: csiph.com!1.us.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!news2.arglkargh.de!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod From: "Kirill A. Shutemov" Newsgroups: linux.kernel Subject: Re: [PATCH 1/2] mm/thp/pagecache: Only withdraw page table after a successful deposit Date: Mon, 12 Dec 2016 22:10:02 +0100 Message-ID: References: Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=m93rbaYLpkchRvEob7nOGHva/YAEOZ1zsOC4Np/1oHU=; b=zu84EcPWFRhU4gmNc9oCyb011pym5DPdDMB7i/SB+524nOoVc6pA+1TIvpt/FqwmM/ f1IFpRXkzMLigSq71V1uKDXiDsTnHKYMr0HNJTexneCSxYe8Rd5Rqs6RbQUwYKBe8k7V t50bzpPdHS6wfb29qRcpskIkP2Ifk7A255/zsijWVNky7kE+ZAyX6zV38LHe65qZMKRc FS3vva0Cm5K8ns4G2BKo6yXM4DZ31hPbeHokE0IlA06NeXfxMYK0fXdO27jF570W7cUI nr1v4bznSHAbO8BcEfgJhcJkfnSOJpxVCvpfMnIoAkRirumD7xclJBdYthJRWmcqRI8K zgcA== X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=m93rbaYLpkchRvEob7nOGHva/YAEOZ1zsOC4Np/1oHU=; b=Lw9+hGKctfUP9Vr40YA797Sr+ePcq48gPIYVbF3i1/PR7xB/8Qp8D7hy4FH55Sxa2K Ya+MudtFCshl4D0Puvp+xk/cyMBVukHWbHkKQ8skqzMrCURPS/LGfDiEpU6t6+LghJjs as3/CN6OGxNJDQo+u4Ib4yFW6PlbNy/hSIq0D8T16RbOMO/HK9FfOqMcqqwnERqvPbhM VVCkPZMWEMViE9WMtfiye8sROaHyHucSsF7giq6EG2mXfQrxcHeeODULUqt0LmlE5t9g xuRM3Y1kdlgPdsm7HAKnBvjdFDK/RsS5WnUC0Dv0/IZparQazfxJlZq3kliISUnLI1SK LA7g== X-Gm-Message-State: AKaTC03Lv65MfW//bLm415cY+3CGZVypqfejb1ksZHQG5DQBn/XWR/CWjk1+bNtRHxwa/g== X-Received: by 10.28.21.21 with SMTP id 21mr18570254wmv.132.1481576479935; Mon, 12 Dec 2016 13:01:19 -0800 (PST) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 16 Organization: linux.* mail to news gateway X-Original-Cc: akpm@linux-foundation.org, "Kirill A . Shutemov" , mpe@ellerman.id.au, linux-mm@kvack.org, linux-kernel@vger.kernel.org X-Original-Date: Tue, 13 Dec 2016 00:01:18 +0300 X-Original-Message-ID: <20161212210118.GB10202@node.shutemov.name> X-Original-References: <20161212163428.6780-1-aneesh.kumar@linux.vnet.ibm.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1540655 On Mon, Dec 12, 2016 at 10:04:27PM +0530, Aneesh Kumar K.V wrote: > The current code wrongly called withdraw in the error path. But we > haven't depoisted the page table yet in the only error path in that > function. So for now remove that withdraw completely. If we take > that "out:" branch, we should have vmf->prealloc_pte already pointing > to the allocated page table. > > Fixes: "mm: THP page cache support for ppc64" > > Signed-off-by: Aneesh Kumar K.V Reported-by: Kirill A. Shutemov Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov