[V1] ata: sata_mv:- Handle return value of devm_ioremap.

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news.roellig-ltd.de!open-news-network.org!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Arvind Yadav <arvind.yadav.cs@gmail.com>
Newsgroups	linux.kernel
Subject	[V1] ata: sata_mv:- Handle return value of devm_ioremap.
Date	Mon, 12 Dec 2016 18:50:01 +0100
Message-ID	<sNCTD-7fH-7@gated-at.bofh.it> (permalink)
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=5p4Ik5r5TmOjnnDw143Qivyer0mwW6DB+wrjAiXODyM=; b=BfzCPUh+1z7c1/W6l1UINMAXH/qqt7eigiabYnPzk9uYwMgmMiibkfZWeqPUJvRkHG 36K1Sa0EdddUvsdSBt9+vpKAtBM4VZxig9ih18pfxx+1FYjGrxOJeK9vP3RF6muaevoY KqJhOZKdT8G1u6HgfmbGMgoAZlXzbEKquc2fnfa6q3ckqO1sH4DWJEwbPRxplSGlBJAd K6rqOhEpRq/4QQJ+58XevdW22kHDNT9zs0dj8QABXShVlGWKD6KtrHwlpBbpONfFNzQN jwgwqn6X+LDeu+v4QqUW7I2JkTEh7ifSBCIN65O4AY/Hfln54VLliggJscluq8yWIq0y fZjA==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=5p4Ik5r5TmOjnnDw143Qivyer0mwW6DB+wrjAiXODyM=; b=PSb/rLCoCTMz7ERpmfTSq4llRKX3QyhyZbhELjjNuutjW3YD8kPVsAuyGGiK1uA+W6 +eRHIlEYrmAgCdRyCeM7o/tNprtBHeFEvqL6jom+FsoMUnIYxJtG3Cojif3+Goit5TOj C/3zJrMkBmY2XD8wOrBnluih/ypZ44oVzDJ14LAG0Da9wgGyOAwv5bTIYYW+FYjvmvAK SnC/0oof7OKcMNmrmeZf2z1c3NQLXBEOJHGse149N2NzfrfRHjp3putlgng4FnLR2IXx O26imw4h82Phlo9RJwaIIYZvBcvxN8FLsiA+kS04DWmNf7GByIXGpNfdljPSBK4beYkP cmLQ==
X-Gm-Message-State	AKaTC03tQJtHOQ6TRREf/Rx7QTzIKhcOhH3JOLD7TuY0pOkyvsllGd/PCpgGEiQ8b5svQg==
X-Received	by 10.99.126.94 with SMTP id o30mr169774969pgn.66.1481564625110; Mon, 12 Dec 2016 09:43:45 -0800 (PST)
X-Mailer	git-send-email 2.7.4
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	26
Organization	linux.* mail to news gateway
X-Original-Cc	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Mon, 12 Dec 2016 23:13:27 +0530
X-Original-Message-ID	<1481564607-9626-1-git-send-email-arvind.yadav.cs@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1540482

Show key headers only | View raw

Here, If devm_ioremap will fail. It will return NULL.
Then hpriv->base = NULL - 0x20000; Kernel can run into
a NULL-pointer dereference. This error check will avoid
NULL pointer dereference.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/ata/sata_mv.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index efc48bf..9d0cdad 100644
--- a/drivers/ata/sata_mv.c
+++ b/drivers/ata/sata_mv.c
@@ -4119,6 +4119,9 @@ static int mv_platform_probe(struct platform_device *pdev)
 	host->iomap = NULL;
 	hpriv->base = devm_ioremap(&pdev->dev, res->start,
 				   resource_size(res));
+	if (!hpriv->base)
+		return -ENOMEM;
+
 	hpriv->base -= SATAHC0_REG_BASE;
 
 	hpriv->clk = clk_get(&pdev->dev, NULL);
-- 
2.7.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[V1] ata: sata_mv:- Handle return value of devm_ioremap. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-12-12 18:50 +0100

csiph-web