Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1540483

Re: [tpmdd-devel] [PATCH v3 1/3] tpm_crb: map locality registers

From Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [tpmdd-devel] [PATCH v3 1/3] tpm_crb: map locality registers
Date 2016-12-12 18:50 +0100
Message-ID <sNCTD-7fH-21@gated-at.bofh.it> (permalink)
References <sLJ3b-83N-7@gated-at.bofh.it> <sLJ3b-83N-13@gated-at.bofh.it> <sNzM6-5s8-7@gated-at.bofh.it> <sNAI9-61i-27@gated-at.bofh.it> <sNAI9-61i-25@gated-at.bofh.it>
Organization Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw


On Mon, Dec 12, 2016 at 03:28:01PM +0000, Winkler, Tomas wrote:
> > 
> > I've tested is completley disjoint from the region pointed by the ACPI device
> > tree (SSDT in PTT's case).
> > 
> > Here's example device from my x250:
> > 
> > Device (TPM)
> > {
> > Name (_HID, "MSFT0101" /* TPM 2.0 Security Device */)  // _HID: Hardware ID
> > Name (_STR, Unicode ("TPM 2.0 Device"))  // _STR: Description String Name
> > (CRS, ResourceTemplate () { Memory32Fixed (ReadOnly,
> >     0x00000000,         // Address Base
> >     0x00001000,         // Address Length
> >     _Y00)
> 
> 
> I'm not sure what is that?
> 
> > Memory32Fixed (ReadOnly,
> >     0xFED70000,         // Address Base
> >     0x00001000,         // Address Length
> >     )
> 
> But 0xFED70000 should point to CCA 

When I implemented originally the driver I followed the MS specification
and used the value from TPM2 ACPI table. 

The driver ioremaps 00000000CCDFF000, not the address from SSDT.

> Tomas
> Thanks

/Jarkko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v3 1/3] tpm_crb: map locality registers Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-12-07 13:00 +0100
  RE: [tpmdd-devel] [PATCH v3 1/3] tpm_crb: map locality registers "Winkler, Tomas" <tomas.winkler@intel.com> - 2016-12-12 15:30 +0100
    RE: [tpmdd-devel] [PATCH v3 1/3] tpm_crb: map locality registers "Winkler, Tomas" <tomas.winkler@intel.com> - 2016-12-12 16:30 +0100
      Re: [tpmdd-devel] [PATCH v3 1/3] tpm_crb: map locality registers Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-12-12 18:50 +0100
    Re: [tpmdd-devel] [PATCH v3 1/3] tpm_crb: map locality registers Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-12-12 16:30 +0100
      Re: [tpmdd-devel] [PATCH v3 1/3] tpm_crb: map locality registers Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-12-12 16:40 +0100
      Re: [tpmdd-devel] [PATCH v3 1/3] tpm_crb: map locality registers Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-12-12 16:40 +0100
        RE: [tpmdd-devel] [PATCH v3 1/3] tpm_crb: map locality registers "Winkler, Tomas" <tomas.winkler@intel.com> - 2016-12-12 17:00 +0100
          Re: [tpmdd-devel] [PATCH v3 1/3] tpm_crb: map locality registers Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-12-12 19:00 +0100
          Re: [tpmdd-devel] [PATCH v3 1/3] tpm_crb: map locality registers Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-12-12 19:00 +0100

csiph-web