Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1539990

Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions

Show all headers | View raw

Yes, It will not fixes any defect. But we are going to free allocate
memory then why we need devm api. In this case Devm will first add this
entry to list and immediately  it will remove from list.

-Arvind

On Saturday 10 December 2016 02:49 PM, Robert Jarzmik wrote:
> Arvind Yadav <arvind.yadav.cs@gmail.com> writes:
>
> Hi Arvind,
>
>> In functions pxa2xx_build_functions, the memory allocated for
>> 'functions' is live within the function only. After the
>> allocation it is immediately freed with devm_kfree. There is
>> no need to allocate memory for 'functions' with devm function
>> so replace devm_kcalloc  with kcalloc and devm_kfree with kfree.
> That's not very true : the "need" is to spare the "manual" kfree you're adding
> in your patch for one, and make it consistent with pxa2xx_build_groups() and
> pxa2xx_build_state() for two.
>
> Therefore I'm not very thrilled by this patch and unless it fixes a defect in
> the driver I'd rather not have it in.
>
> Cheers.
>
> --
> Robert

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions Arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-12-08 15:40 +0100
  Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions Robin Murphy <robin.murphy@arm.com> - 2016-12-08 16:30 +0100
  Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions Robin Murphy <robin.murphy@arm.com> - 2016-12-08 16:30 +0100
  Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions Robert Jarzmik <robert.jarzmik@free.fr> - 2016-12-10 10:20 +0100
    Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-12-11 09:10 +0100
  Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions Linus Walleij <linus.walleij@linaro.org> - 2016-12-27 13:50 +0100
    Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions Robert Jarzmik <robert.jarzmik@free.fr> - 2016-12-29 08:30 +0100
      Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions Linus Walleij <linus.walleij@linaro.org> - 2016-12-30 14:10 +0100

csiph-web