Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1536904
| From | Stefan Eichenberger <eichest@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 net-next v2 4/4] net: dsa: mv88e6xxx: add PPU operations |
| Date | 2016-12-06 13:30 +0100 |
| Message-ID | <sLn2F-1ZI-7@gated-at.bofh.it> (permalink) |
| References | <sL4jo-6RL-13@gated-at.bofh.it> <sL4jo-6RL-19@gated-at.bofh.it> <sL8Gl-1fF-15@gated-at.bofh.it> <sL9M5-1XN-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 5 December 2016 at 23:18, Vivien Didelot
<vivien.didelot@savoirfairelinux.com> wrote:
> Stefan Eichenberger <eichest@gmail.com> writes:
>
>> Hi Vivien,
>>
>> On Mon, Dec 05, 2016 at 11:27:03AM -0500, Vivien Didelot wrote:
>>> @@ -3266,6 +3220,8 @@ static const struct mv88e6xxx_ops mv88e6097_ops = {
>>> .g1_set_cpu_port = mv88e6095_g1_set_cpu_port,
>>> .g1_set_egress_port = mv88e6095_g1_set_egress_port,
>>> .mgmt_rsvd2cpu = mv88e6095_g2_mgmt_rsvd2cpu,
>>> + .ppu_enable = mv88e6185_g1_ppu_enable,
>>> + .ppu_disable = mv88e6185_g1_ppu_disable,
>>> .reset = mv88e6185_g1_reset,
>>> };
>>
>> The mv88e6097 should use the indirect access to the phys, bit 14 in g1
>> control is marked as reserved. They write in the datasheet that
>> disabling the PPU is still supported but indirect access via g2 should
>> be used because disabling the PPU is no longer recommended.
>
> Ho ok thanks, I respin a v3 right away with this removed and with
> mv88e6352_g1_reset instead.
Perfect thank you, now it's fine.
Regards,
Stefan
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 net-next v2 0/4] net: dsa: mv88e6xxx: rework reset and PPU code Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-12-05 17:30 +0100
[PATCH v2 net-next v2 4/4] net: dsa: mv88e6xxx: add PPU operations Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-12-05 17:30 +0100
Re: [PATCH v2 net-next v2 4/4] net: dsa: mv88e6xxx: add PPU operations Stefan Eichenberger <eichest@gmail.com> - 2016-12-05 22:10 +0100
Re: [PATCH v2 net-next v2 4/4] net: dsa: mv88e6xxx: add PPU operations Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-12-05 23:20 +0100
Re: [PATCH v2 net-next v2 4/4] net: dsa: mv88e6xxx: add PPU operations Stefan Eichenberger <eichest@gmail.com> - 2016-12-06 13:30 +0100
[PATCH v2 net-next v2 2/4] net: dsa: mv88e6xxx: add helper to hardware reset Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-12-05 17:30 +0100
[PATCH v2 net-next v2 1/4] net: dsa: mv88e6xxx: add helper to disable ports Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-12-05 17:40 +0100
[PATCH v2 net-next v2 3/4] net: dsa: mv88e6xxx: add a soft reset operation Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-12-05 17:40 +0100
Re: [PATCH v2 net-next v2 3/4] net: dsa: mv88e6xxx: add a soft reset operation Stefan Eichenberger <eichest@gmail.com> - 2016-12-05 22:30 +0100
csiph-web