Re: [PATCH] net:switchdev: fix to release the lock before function return to avoid deadlock

From	Jiri Pirko <jiri@resnulli.us>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net:switchdev: fix to release the lock before function return to avoid deadlock
Date	2016-12-06 13:30 +0100
Message-ID	<sLn2F-1ZI-15@gated-at.bofh.it> (permalink)
References	<sLn2F-1ZI-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Tue, Dec 06, 2016 at 11:09:24AM CET, feng.deng@cortina-access.com wrote:
>before switchdev_deferred_dequeue() normal return,show release the lock,
>if not,maybe there will be deadlock sometimes
>
>Signed-off-by: Feng Deng <feng.deng@cortina-access.com>
>---
> net/switchdev/switchdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/net/switchdev/switchdev.c b/net/switchdev/switchdev.c
>index 3b95fe9..c0a1ad4 100644
>--- a/net/switchdev/switchdev.c
>+++ b/net/switchdev/switchdev.c
>@@ -120,6 +120,7 @@ static struct switchdev_deferred_item *switchdev_deferred_dequeue(void)
> 	dfitem = list_first_entry(&deferred,
> 				  struct switchdev_deferred_item, list);
> 	list_del(&dfitem->list);
>+	spin_unlock_bh(&deferred_lock);
> unlock:
> 	spin_unlock_bh(&deferred_lock);

You are joking right?

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] net:switchdev: fix to release the lock before function  return to avoid deadlock Jiri Pirko <jiri@resnulli.us> - 2016-12-06 13:30 +0100

csiph-web